http://www.mediawiki.org/wiki/Special:Code/MediaWiki/73749
Revision: 73749
Author: reedy
Date: 2010-09-25 16:37:39 +0000 (Sat, 25 Sep 2010)
Log Message:
-----------
Remove some unused variables
Tweak php doc, "One" is not a type, so insert string in there
Modified Paths:
--------------
trunk/phase3/includes/api/ApiBase.php
trunk/phase3/includes/api/ApiDelete.php
trunk/phase3/includes/api/ApiImport.php
trunk/phase3/includes/api/ApiMain.php
trunk/phase3/includes/api/ApiQueryUsers.php
Modified: trunk/phase3/includes/api/ApiBase.php
===================================================================
--- trunk/phase3/includes/api/ApiBase.php 2010-09-25 16:09:16 UTC (rev
73748)
+++ trunk/phase3/includes/api/ApiBase.php 2010-09-25 16:37:39 UTC (rev
73749)
@@ -181,8 +181,7 @@
if ( isset( $data['warnings'][$this->getModuleName()] ) ) {
// Don't add duplicate warnings
$warn_regex = preg_quote( $warning, '/' );
- if ( preg_match( "/{$warn_regex}(\\n|$)/",
$data['warnings'][$this->getModuleName()]['*'] ) )
- {
+ if ( preg_match( "/{$warn_regex}(\\n|$)/",
$data['warnings'][$this->getModuleName()]['*'] ) ) {
return;
}
$oldwarning =
$data['warnings'][$this->getModuleName()]['*'];
Modified: trunk/phase3/includes/api/ApiDelete.php
===================================================================
--- trunk/phase3/includes/api/ApiDelete.php 2010-09-25 16:09:16 UTC (rev
73748)
+++ trunk/phase3/includes/api/ApiDelete.php 2010-09-25 16:37:39 UTC (rev
73749)
@@ -82,7 +82,6 @@
$this->dieUsageMsg( reset( $retval ) ); // We
don't care about multiple errors, just report one of them
}
- $watch = 'nochange';
// Deprecated parameters
if ( $params['watch'] ) {
$watch = 'watch';
Modified: trunk/phase3/includes/api/ApiImport.php
===================================================================
--- trunk/phase3/includes/api/ApiImport.php 2010-09-25 16:09:16 UTC (rev
73748)
+++ trunk/phase3/includes/api/ApiImport.php 2010-09-25 16:37:39 UTC (rev
73749)
@@ -47,7 +47,6 @@
}
$params = $this->extractRequestParams();
- $source = null;
$isUpload = false;
if ( isset( $params['interwikisource'] ) ) {
if ( !isset( $params['interwikipage'] ) ) {
Modified: trunk/phase3/includes/api/ApiMain.php
===================================================================
--- trunk/phase3/includes/api/ApiMain.php 2010-09-25 16:09:16 UTC (rev
73748)
+++ trunk/phase3/includes/api/ApiMain.php 2010-09-25 16:37:39 UTC (rev
73749)
@@ -220,7 +220,7 @@
/**
* Set the type of caching headers which will be sent.
*
- * @param $mode One of:
+ * @param $mode String One of:
* - 'public': Cache this object in public caches, if the maxage
or smaxage
* parameter is set, or if setCacheMaxAge() was called. If a
maximum age is
* not provided by any of these means, the object will be
private.
Modified: trunk/phase3/includes/api/ApiQueryUsers.php
===================================================================
--- trunk/phase3/includes/api/ApiQueryUsers.php 2010-09-25 16:09:16 UTC (rev
73748)
+++ trunk/phase3/includes/api/ApiQueryUsers.php 2010-09-25 16:37:39 UTC (rev
73749)
@@ -73,7 +73,6 @@
public function execute() {
$params = $this->extractRequestParams();
- $result = $this->getResult();
if ( !is_null( $params['prop'] ) ) {
$this->prop = array_flip( $params['prop'] );
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
