http://www.mediawiki.org/wiki/Special:Code/MediaWiki/73753
Revision: 73753
Author: reedy
Date: 2010-09-25 16:56:03 +0000 (Sat, 25 Sep 2010)
Log Message:
-----------
Remove some unused keys from foreach
Documentation tweaks
Modified Paths:
--------------
trunk/phase3/includes/api/ApiFormatXml.php
trunk/phase3/includes/api/ApiMain.php
trunk/phase3/includes/api/ApiQueryImageInfo.php
trunk/phase3/includes/api/ApiUpload.php
Modified: trunk/phase3/includes/api/ApiFormatXml.php
===================================================================
--- trunk/phase3/includes/api/ApiFormatXml.php 2010-09-25 16:49:21 UTC (rev
73752)
+++ trunk/phase3/includes/api/ApiFormatXml.php 2010-09-25 16:56:03 UTC (rev
73753)
@@ -155,7 +155,7 @@
$retval .= self::recXmlPrint(
$subElemId, $subElemValue, $indent );
}
- foreach ( $indElements as $subElemId =>
& $subElemValue ) {
+ foreach ( $indElements as
&$subElemValue ) {
$retval .= self::recXmlPrint(
$subElemIndName, $subElemValue, $indent );
}
Modified: trunk/phase3/includes/api/ApiMain.php
===================================================================
--- trunk/phase3/includes/api/ApiMain.php 2010-09-25 16:49:21 UTC (rev
73752)
+++ trunk/phase3/includes/api/ApiMain.php 2010-09-25 16:56:03 UTC (rev
73753)
@@ -583,7 +583,7 @@
/**
* Check for sufficient permissions to execute
- * @param $module object An Api module
+ * @param $module ApiBase An Api module
*/
protected function checkExecutePermissions( $module ) {
global $wgUser;
@@ -607,7 +607,7 @@
/**
* Check POST for external response and setup result printer
- * @param $module object An Api module
+ * @param $module ApiBase An Api module
* @param $params Array an array with the request parameters
*/
protected function setupExternalResponse( $module, $params ) {
Modified: trunk/phase3/includes/api/ApiQueryImageInfo.php
===================================================================
--- trunk/phase3/includes/api/ApiQueryImageInfo.php 2010-09-25 16:49:21 UTC
(rev 73752)
+++ trunk/phase3/includes/api/ApiQueryImageInfo.php 2010-09-25 16:56:03 UTC
(rev 73753)
@@ -264,6 +264,11 @@
return $vals;
}
+ /*
+ *
+ * param $metadata Array
+ * param $result ApiResult
+ */
public static function processMetaData( $metadata, $result ) {
$retval = array();
if ( is_array( $metadata ) ) {
Modified: trunk/phase3/includes/api/ApiUpload.php
===================================================================
--- trunk/phase3/includes/api/ApiUpload.php 2010-09-25 16:49:21 UTC (rev
73752)
+++ trunk/phase3/includes/api/ApiUpload.php 2010-09-25 16:56:03 UTC (rev
73753)
@@ -285,7 +285,7 @@
if ( isset( $warnings['duplicate'] ) ) {
$dupes = array();
- foreach ( $warnings['duplicate'] as $key => $dupe ) {
+ foreach ( $warnings['duplicate'] as $dupe ) {
$dupes[] = $dupe->getName();
}
$this->getResult()->setIndexedTagName( $dupes,
'duplicate' );
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
