http://www.mediawiki.org/wiki/Special:Code/MediaWiki/73933
Revision: 73933
Author: nikerabbit
Date: 2010-09-29 07:35:51 +0000 (Wed, 29 Sep 2010)
Log Message:
-----------
Rename and split hooks for clarity
Modified Paths:
--------------
trunk/extensions/Translate/Translate.php
trunk/extensions/Translate/tag/PageTranslationHooks.php
Modified: trunk/extensions/Translate/Translate.php
===================================================================
--- trunk/extensions/Translate/Translate.php 2010-09-29 01:23:32 UTC (rev
73932)
+++ trunk/extensions/Translate/Translate.php 2010-09-29 07:35:51 UTC (rev
73933)
@@ -523,7 +523,9 @@
$wgHooks['ArticleSaveComplete'][] =
'PageTranslationHooks::addTranstag';
// Prevent editing of unknown pages in Translations namespace
- $wgHooks['getUserPermissionsErrorsExpensive'][] =
'PageTranslationHooks::translationsCheck';
+ $wgHooks['getUserPermissionsErrorsExpensive'][] =
'PageTranslationHooks::preventUnknownTranslations';
+ // Prevent editing of translation pages directly
+ $wgHooks['getUserPermissionsErrorsExpensive'][] =
'PageTranslationHooks::preventDirectEditing';
// Locking during page moves
$wgHooks['getUserPermissionsErrorsExpensive'][] =
'PageTranslationHooks::lockedPagesCheck';
Modified: trunk/extensions/Translate/tag/PageTranslationHooks.php
===================================================================
--- trunk/extensions/Translate/tag/PageTranslationHooks.php 2010-09-29
01:23:32 UTC (rev 73932)
+++ trunk/extensions/Translate/tag/PageTranslationHooks.php 2010-09-29
07:35:51 UTC (rev 73933)
@@ -303,23 +303,23 @@
return true;
}
- // Here we disable editing of some existing or unknown pages
- public static function translationsCheck( $title, $user, $action,
&$result ) {
- // Case 1: Unknown section translations
+ /// Prevent editing of unknown pages in Translations namespace
+ public static function preventUnknownTranslations( $title, $user,
$action, &$result ) {
if ( $title->getNamespace() == NS_TRANSLATIONS && $action ===
'edit' ) {
$group = self::titleToGroup( $title );
if ( $group === null ) {
// No group means that the page is currently not
// registered to any page translation message
groups
$result = array( 'tpt-unknown-page' );
-
return false;
}
-
- return true;
}
- // Case 2: Target pages
+ return true;
+ }
+
+ /// Prevent editing of translation pages directly
+ public static function preventDirectEditing( $title, $user, $action,
&$result ) {
$page = TranslatablePage::isTranslationPage( $title );
if ( $page !== false ) {
if ( self::$allowTargetEdit ) {
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
