http://www.mediawiki.org/wiki/Special:Code/MediaWiki/73979
Revision: 73979
Author: simetrical
Date: 2010-09-29 20:13:38 +0000 (Wed, 29 Sep 2010)
Log Message:
-----------
Backport r73978 "Fix IEFixes.js loading again"
Original commit message:
Bug 25167. The fix in r65774 was wrong -- apparently I didn't test well
enough. I've tested the new fix by loading IE6 and requesting a page
from my wiki without it, verifying with Wireshark that no HTTP request
was sent for IEFixes.js, and then repeating with the fix applied to
verify it works.
Will backport to 1.16, like r65774, since this is still a regression
from 1.15. Note that only IE6 and less were ever affected, and things
seem to be mostly usable without the fixes file, so I don't think this
is of enormous importance.
Modified Paths:
--------------
branches/REL1_16/phase3/RELEASE-NOTES
branches/REL1_16/phase3/skins/common/wikibits.js
Modified: branches/REL1_16/phase3/RELEASE-NOTES
===================================================================
--- branches/REL1_16/phase3/RELEASE-NOTES 2010-09-29 20:05:16 UTC (rev
73978)
+++ branches/REL1_16/phase3/RELEASE-NOTES 2010-09-29 20:13:38 UTC (rev
73979)
@@ -50,6 +50,7 @@
* (bug 24166) API error when using rvprop=tags
* For wikis setup in French language, Special:Téléchargement works again
as an alias for Special:Upload
+* (bug 25167) Correctly load JS fixes for IE6 (fixing a regression in 1.16.0)
== Changes since 1.16 beta 3 ==
Modified: branches/REL1_16/phase3/skins/common/wikibits.js
===================================================================
--- branches/REL1_16/phase3/skins/common/wikibits.js 2010-09-29 20:05:16 UTC
(rev 73978)
+++ branches/REL1_16/phase3/skins/common/wikibits.js 2010-09-29 20:13:38 UTC
(rev 73979)
@@ -29,7 +29,7 @@
// avoiding false positives from moronic extensions that append to the IE UA
// string (bug 23171)
var ie6_bugs = false;
-if ( /MSIE ([0-9]{1,}[\.0-9]{0,})/.exec( clientPC ) != null
+if ( /msie ([0-9]{1,}[\.0-9]{0,})/.exec( clientPC ) != null
&& parseFloat( RegExp.$1 ) <= 6.0 ) {
ie6_bugs = true;
}
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
