http://www.mediawiki.org/wiki/Special:Code/MediaWiki/74003

Revision: 74003
Author:   jeroendedauw
Date:     2010-09-29 23:19:24 +0000 (Wed, 29 Sep 2010)

Log Message:
-----------
Added FIXME for issue caused by resource loader changes

Modified Paths:
--------------
    trunk/extensions/SemanticMediaWiki/includes/SMW_Outputs.php

Modified: trunk/extensions/SemanticMediaWiki/includes/SMW_Outputs.php
===================================================================
--- trunk/extensions/SemanticMediaWiki/includes/SMW_Outputs.php 2010-09-29 
23:09:51 UTC (rev 74002)
+++ trunk/extensions/SemanticMediaWiki/includes/SMW_Outputs.php 2010-09-29 
23:19:24 UTC (rev 74003)
@@ -1,12 +1,4 @@
 <?php
-/**
- * This file contains the SMWOutputs class.
- *
- * @author Markus Krötzsch
- *
- * @file
- * @ingroup SMW
- */
 
 /**
  * This class attempts to provide safe yet simple means for managing data that 
is relevant
@@ -28,12 +20,15 @@
  * that creates SMW outputs that may require head items must afterwards clear 
the temporal store by
  * writing its contents to the according output.
  *
+ * @file SMW_Ouputs.php
  * @ingroup SMW
+ * 
+ * @author Markus Krötzsch
  */
 class SMWOutputs {
 
-       /// Protected member function for temporarily storing header items
-       static protected $mHeadItems = array();
+       /// Protected member function for temporarily storing header items.
+       protected static $mHeadItems = array();
 
        /**
         * Announce that some head item (usually CSS or JavaScript) is required 
to
@@ -54,6 +49,9 @@
         * @param $id string or predefined constant for identifying a head item
         * @param $item string containing a complete HTML-compatibly text 
snippet that
         * should go into the HTML header; only required if $id is no built-in 
constant.
+        * 
+        * FIXME: switch on precence of the resource loader (introduced in MW 
1.17).
+        *        SMW_sorttable.js uses addOnloadHook and breaks as it is now 
on 1.17.
         */
        static public function requireHeadItem( $id, $item = '' ) {
                if ( is_numeric( $id ) ) {
@@ -129,7 +127,6 @@
         * @param ParserOutput $parserOutput
         */
        static public function commitToParserOutput( ParserOutput $parserOutput 
) {
-               // debug_zval_dump(self::$mItems);
                foreach ( self::$mHeadItems as $key => $item ) {
                        $parserOutput->addHeadItem( "\t\t" . $item . "\n", $key 
);
                }
@@ -154,4 +151,5 @@
 
                self::$mHeadItems = array();
        }
+       
 }
\ No newline at end of file



_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to