http://www.mediawiki.org/wiki/Special:Code/MediaWiki/74150

Revision: 74150
Author:   bawolff
Date:     2010-10-02 20:36:23 +0000 (Sat, 02 Oct 2010)

Log Message:
-----------
Fix undefined variable notice if $wgHiddenPrefs[] = 'fancysig'.

Use !empty($blah) since that is what the rest of the code is doing. This does
not change the behaviour in any way, only gets rid of the warning. Issue
discovered by jorenl on irc.

Modified Paths:
--------------
    trunk/phase3/includes/Preferences.php

Modified: trunk/phase3/includes/Preferences.php
===================================================================
--- trunk/phase3/includes/Preferences.php       2010-10-02 19:58:17 UTC (rev 
74149)
+++ trunk/phase3/includes/Preferences.php       2010-10-02 20:36:23 UTC (rev 
74150)
@@ -1117,7 +1117,7 @@
 
        static function cleanSignature( $signature, $alldata ) {
                global $wgParser;
-               if ( $alldata['fancysig'] ) {
+               if ( !empty( $alldata['fancysig'] ) ) {
                        $signature = $wgParser->cleanSig( $signature );
                } else {
                        // When no fancy sig used, make sure ~{3,5} get removed.



_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to