http://www.mediawiki.org/wiki/Special:Code/MediaWiki/76191
Revision: 76191
Author: reedy
Date: 2010-11-06 15:10:18 +0000 (Sat, 06 Nov 2010)
Log Message:
-----------
Add missing credits from r75975
Remove a few unused array keys in API foreach loops
Remove part of Html::Hidden comment
Modified Paths:
--------------
trunk/phase3/CREDITS
trunk/phase3/includes/Html.php
trunk/phase3/includes/api/ApiMain.php
trunk/phase3/includes/api/ApiPageSet.php
trunk/phase3/includes/api/ApiParse.php
Modified: trunk/phase3/CREDITS
===================================================================
--- trunk/phase3/CREDITS 2010-11-06 13:12:55 UTC (rev 76190)
+++ trunk/phase3/CREDITS 2010-11-06 15:10:18 UTC (rev 76191)
@@ -91,6 +91,7 @@
* Jidanni
* Jimmy Xu
* John Du Hart
+* Jonathan Wiltshire
* Karun Dambietz
* Kim Hyun-Joon
* Lee Worden
Modified: trunk/phase3/includes/Html.php
===================================================================
--- trunk/phase3/includes/Html.php 2010-11-06 13:12:55 UTC (rev 76190)
+++ trunk/phase3/includes/Html.php 2010-11-06 15:10:18 UTC (rev 76191)
@@ -547,8 +547,7 @@
}
/**
- * Convenience function to produce an input element with type=hidden,
like
- * Xml::hidden.
+ * Convenience function to produce an input element with type=hidden
*
* @param $name string name attribute
* @param $value string value attribute
Modified: trunk/phase3/includes/api/ApiMain.php
===================================================================
--- trunk/phase3/includes/api/ApiMain.php 2010-11-06 13:12:55 UTC (rev
76190)
+++ trunk/phase3/includes/api/ApiMain.php 2010-11-06 15:10:18 UTC (rev
76191)
@@ -833,7 +833,7 @@
$astriks = str_repeat( '*** ', 10 );
$msg .= "\n\n$astriks Modules $astriks\n\n";
- foreach ( $this->mModules as $moduleName => $unused ) {
+ foreach ( $this->mModules as $moduleName ) {
$module = new $this->mModules[$moduleName] ( $this,
$moduleName );
$msg .= self::makeHelpMsgHeader( $module, 'action' );
$msg2 = $module->makeHelpMsg();
@@ -852,7 +852,7 @@
}
$msg .= "\n$astriks Formats $astriks\n\n";
- foreach ( $this->mFormats as $formatName => $unused ) {
+ foreach ( $this->mFormats as $formatName ) {
$module = $this->createPrinterByName( $formatName );
$msg .= self::makeHelpMsgHeader( $module, 'format' );
$msg2 = $module->makeHelpMsg();
Modified: trunk/phase3/includes/api/ApiPageSet.php
===================================================================
--- trunk/phase3/includes/api/ApiPageSet.php 2010-11-06 13:12:55 UTC (rev
76190)
+++ trunk/phase3/includes/api/ApiPageSet.php 2010-11-06 15:10:18 UTC (rev
76191)
@@ -501,7 +501,7 @@
if ( $processTitles ) {
// The remaining titles in $remaining are
non-existent pages
foreach ( $remaining as $ns => $dbkeys ) {
- foreach ( $dbkeys as $dbkey => $unused
) {
+ foreach ( $dbkeys as $dbkey ) {
$title = Title::makeTitle( $ns,
$dbkey );
$this->mAllPages[$ns][$dbkey] =
$this->mFakePageId;
$this->mMissingTitles[$this->mFakePageId] = $title;
Modified: trunk/phase3/includes/api/ApiParse.php
===================================================================
--- trunk/phase3/includes/api/ApiParse.php 2010-11-06 13:12:55 UTC (rev
76190)
+++ trunk/phase3/includes/api/ApiParse.php 2010-11-06 15:10:18 UTC (rev
76191)
@@ -345,7 +345,7 @@
private function formatIWLinks( $iw ) {
$result = array();
foreach ( $iw as $prefix => $titles ) {
- foreach ( $titles as $title => $id ) {
+ foreach ( $titles as $title ) {
$entry = array();
$entry['prefix'] = $prefix;
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
