http://www.mediawiki.org/wiki/Special:Code/MediaWiki/76237
Revision: 76237
Author: catrope
Date: 2010-11-07 09:44:36 +0000 (Sun, 07 Nov 2010)
Log Message:
-----------
Superficially fix up the WikiSync extension to work with ResourceLoader. Closed
an unclosed iframe tag in the special page output and exported a few variables
to the global scope using window.varname .
Modified Paths:
--------------
trunk/extensions/WikiSync/WikiSync.js
trunk/extensions/WikiSync/WikiSyncPage.php
trunk/extensions/WikiSync/WikiSync_utils.js
Modified: trunk/extensions/WikiSync/WikiSync.js
===================================================================
--- trunk/extensions/WikiSync/WikiSync.js 2010-11-07 09:40:34 UTC (rev
76236)
+++ trunk/extensions/WikiSync/WikiSync.js 2010-11-07 09:44:36 UTC (rev
76237)
@@ -33,7 +33,7 @@
* @addtogroup Extensions
*/
-var WikiSync = {
+window.WikiSync = {
_WikiSync : '', // WikiSync context
@@ -969,4 +969,4 @@
}
-WikiSyncUtils.addEvent(window,"load",WikiSync.onloadHandler);
+WikiSyncUtils.addEvent(window,"load", WikiSync.onloadHandler);
Modified: trunk/extensions/WikiSync/WikiSyncPage.php
===================================================================
--- trunk/extensions/WikiSync/WikiSyncPage.php 2010-11-07 09:40:34 UTC (rev
76236)
+++ trunk/extensions/WikiSync/WikiSyncPage.php 2010-11-07 09:44:36 UTC (rev
76237)
@@ -154,7 +154,9 @@
),
array( '__tag'=>'tr',
array( '__tag'=>'td', 'colspan'=>'2',
- array( '__tag'=> 'iframe',
'id'=>'wikisync_iframe', 'style' => 'width:100%; height:200px; display:none; ' )
+ // Have to explicitly set empty
contents for the iframe, or we'll produce
+ // <iframe /> which browsers
consider an unclosed tag
+ array( '__tag'=> 'iframe',
'id'=>'wikisync_iframe', 'style' => 'width:100%; height:200px; display:none; ',
'' )
)
)
);
Modified: trunk/extensions/WikiSync/WikiSync_utils.js
===================================================================
--- trunk/extensions/WikiSync/WikiSync_utils.js 2010-11-07 09:40:34 UTC (rev
76236)
+++ trunk/extensions/WikiSync/WikiSync_utils.js 2010-11-07 09:44:36 UTC (rev
76237)
@@ -1,4 +1,4 @@
-var WikiSyncUtils = {
+window.WikiSyncUtils = {
// browser-independent addevent function
addEvent : function ( obj, type, fn ) {
if ( document.getElementById && document.createTextNode ) {
@@ -38,7 +38,7 @@
* percents indicator class
* @param id - id of table container for percents indicator
*/
-function WikiSyncPercentsIndicator( id ) {
+window.WikiSyncPercentsIndicator = function( id ) {
this.topElement = document.getElementById( id );
var tr1 = this.topElement.firstChild.firstChild;
// description line will be stored there
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
