http://www.mediawiki.org/wiki/Special:Code/MediaWiki/76295
Revision: 76295
Author: ialex
Date: 2010-11-08 10:22:54 +0000 (Mon, 08 Nov 2010)
Log Message:
-----------
Removed some error suppression operators
Modified Paths:
--------------
trunk/phase3/includes/Math.php
Modified: trunk/phase3/includes/Math.php
===================================================================
--- trunk/phase3/includes/Math.php 2010-11-08 10:22:41 UTC (rev 76294)
+++ trunk/phase3/includes/Math.php 2010-11-08 10:22:54 UTC (rev 76295)
@@ -154,7 +154,10 @@
$hashpath = $this->_getHashPath();
if( !file_exists( $hashpath ) ) {
- if( !...@wfmkdirparents( $hashpath, 0755 ) ) {
+ wfSuppressWarnings();
+ $ret = wfMkdirParents( $hashpath, 0755 );
+ wfRestoreWarnings();
+ if( !$ret ) {
return $this->_error( 'math_bad_output'
);
}
} elseif( !is_dir( $hashpath ) || !is_writable(
$hashpath ) ) {
@@ -232,7 +235,9 @@
if( file_exists( $filename ) ) {
if( filesize( $filename ) == 0 ) {
// Some horrible error corrupted stuff
:(
- @unlink( $filename );
+ wfSuppressWarnings();
+ unlink( $filename );
+ wfRestoreWarnings();
} else {
return true;
}
@@ -242,7 +247,10 @@
$hashpath = $this->_getHashPath();
if( !file_exists( $hashpath ) ) {
- if( !...@wfmkdirparents( $hashpath,
0755 ) ) {
+ wfSuppressWarnings();
+ $ret = wfMkdirParents( $hashpath, 0755
);
+ wfRestoreWarnings();
+ if( !$ret ) {
return false;
}
} elseif( !is_dir( $hashpath ) || !is_writable(
$hashpath ) ) {
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
