http://www.mediawiki.org/wiki/Special:Code/MediaWiki/76316
Revision: 76316
Author: krinkle
Date: 2010-11-08 17:01:12 +0000 (Mon, 08 Nov 2010)
Log Message:
-----------
Making comments added in r76283 more clear + added mw.html to test suite
Modified Paths:
--------------
trunk/phase3/resources/mediawiki/mediawiki.js
trunk/phase3/resources/mediawiki.util/mediawiki.util.test.js
Modified: trunk/phase3/resources/mediawiki/mediawiki.js
===================================================================
--- trunk/phase3/resources/mediawiki/mediawiki.js 2010-11-08 16:30:53 UTC
(rev 76315)
+++ trunk/phase3/resources/mediawiki/mediawiki.js 2010-11-08 17:01:12 UTC
(rev 76316)
@@ -968,11 +968,11 @@
s += ' ' + attrName + '="' + this.escape(
attrs[attrName] ) + '"';
}
if ( typeof contents == 'undefined' || contents ===
null ) {
- // Short close tag
+ // Self close tag
s += '/>';
return s;
}
- // Regular close tag
+ // Regular open tag
s += '>';
if (typeof contents === 'string') {
// Escaped
Modified: trunk/phase3/resources/mediawiki.util/mediawiki.util.test.js
===================================================================
--- trunk/phase3/resources/mediawiki.util/mediawiki.util.test.js
2010-11-08 16:30:53 UTC (rev 76315)
+++ trunk/phase3/resources/mediawiki.util/mediawiki.util.test.js
2010-11-08 17:01:12 UTC (rev 76316)
@@ -68,6 +68,8 @@
'object (string)');
mw.test.addTest('typeof
mw.util',
'object (string)');
+ mw.test.addTest('typeof
mw.html',
+ 'object (string)');
mw.test.addTest('typeof
String.prototype.ucFirst',
'function (string)');
mw.test.addTest('\'mediawiki\'.ucFirst()',
@@ -88,16 +90,22 @@
'function (string)');
mw.test.addTest('mw.util.getParamValue( \'action\' )',
'mwutiltest (string)');
+
mw.test.addTest('mw.util.getParamValue( \'foo\',
\'http://mw.org/?foo=wrong&foo=right#&foo=bad\' )',
+ 'right (string)');
mw.test.addTest('mw.util.tooltipAccessKeyRegexp.constructor.name',
'RegExp (string)');
mw.test.addTest('typeof
mw.util.updateTooltipAccessKeys',
'function (string)');
mw.test.addTest('typeof
mw.util.addPortletLink',
'function (string)');
- mw.test.addTest('typeof
mw.util.addPortletLink("p-tb", "http://mediawiki.org/";, "MediaWiki.org",
"t-mworg", "Go to MediaWiki.org ", "m", "#t-print")',
+ mw.test.addTest('typeof
mw.util.addPortletLink( "p-tb", "http://mediawiki.org/";, "MediaWiki.org",
"t-mworg", "Go to MediaWiki.org ", "m", "#t-print" )',
'object (string)');
- mw.test.addTest('a =
mw.util.addPortletLink("p-tb", "http://mediawiki.org/";, "MediaWiki.org",
"t-mworg", "Go to MediaWiki.org ", "m", "#t-print"); $(a).text();',
+ mw.test.addTest('a =
mw.util.addPortletLink( "p-tb", "http://mediawiki.org/";, "MediaWiki.org",
"t-mworg", "Go to MediaWiki.org ", "m", "#t-print" ); $(a).text();',
'MediaWiki.org
(string)');
+
mw.test.addTest('mw.html.element( \'hr\' )',
+ '<hr/> (string)');
+
mw.test.addTest('mw.html.element( \'img\', { \'src\':
\'http://mw.org/?title=Main page&action=edit\' } )',
+ '<img
src="http://mw.org/?title=Main page&action=edit"/> (string)');
// Run tests and compare results
var exec,
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
