http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82880
Revision: 82880
Author: reedy
Date: 2011-02-27 00:36:10 +0000 (Sun, 27 Feb 2011)
Log Message:
-----------
$somevariable; doesn't count as defining a variable
Modified Paths:
--------------
trunk/phase3/tests/RunSeleniumTests.php
trunk/phase3/tests/phpunit/includes/SeleniumConfigurationTest.php
Modified: trunk/phase3/tests/RunSeleniumTests.php
===================================================================
--- trunk/phase3/tests/RunSeleniumTests.php 2011-02-27 00:29:21 UTC (rev
82879)
+++ trunk/phase3/tests/RunSeleniumTests.php 2011-02-27 00:36:10 UTC (rev
82880)
@@ -153,9 +153,9 @@
public function execute() {
global $wgServer, $wgScriptPath, $wgHooks;
- $seleniumSettings;
- $seleniumBrowsers;
- $seleniumTestSuites;
+ $seleniumSettings = array();
+ $seleniumBrowsers = array();
+ $seleniumTestSuites = array();
$configFile = $this->getOption( 'seleniumConfig', '' );
if ( strlen( $configFile ) > 0 ) {
Modified: trunk/phase3/tests/phpunit/includes/SeleniumConfigurationTest.php
===================================================================
--- trunk/phase3/tests/phpunit/includes/SeleniumConfigurationTest.php
2011-02-27 00:29:21 UTC (rev 82879)
+++ trunk/phase3/tests/phpunit/includes/SeleniumConfigurationTest.php
2011-02-27 00:36:10 UTC (rev 82880)
@@ -121,9 +121,9 @@
* @group SeleniumFramework
*/
public function testErrorOnIncorrectConfigFile() {
- $seleniumSettings;
- $seleniumBrowsers;
- $seleniumTestSuites;
+ $seleniumSettings = array();
+ $seleniumBrowsers = array();
+ $seleniumTestSuites = array();
SeleniumConfig::getSeleniumSettings($seleniumSettings,
$seleniumBrowsers,
@@ -137,9 +137,9 @@
* @group SeleniumFramework
*/
public function testErrorOnMissingConfigFile() {
- $seleniumSettings;
- $seleniumBrowsers;
- $seleniumTestSuites;
+ $seleniumSettings = array();
+ $seleniumBrowsers = array();
+ $seleniumTestSuites = array();
global $wgSeleniumConfigFile;
$wgSeleniumConfigFile = '';
SeleniumConfig::getSeleniumSettings($seleniumSettings,
@@ -151,9 +151,9 @@
* @group SeleniumFramework
*/
public function testUsesGlobalVarForConfigFile() {
- $seleniumSettings;
- $seleniumBrowsers;
- $seleniumTestSuites;
+ $seleniumSettings = array();
+ $seleniumBrowsers = array();
+ $seleniumTestSuites = array();
global $wgSeleniumConfigFile;
$this->writeToTempFile( $this->testConfig0 );
$wgSeleniumConfigFile = $this->tempFileName;
@@ -177,9 +177,9 @@
*/
public function testgetSeleniumSettings($sampleConfig,
$expectedSettings, $expectedBrowsers, $expectedSuites ) {
$this->writeToTempFile( $sampleConfig );
- $seleniumSettings;
- $seleniumBrowsers;
- $seleniumTestSuites;
+ $seleniumSettings = array();
+ $seleniumBrowsers = array();
+ $seleniumTestSuites = array();
SeleniumConfig::getSeleniumSettings($seleniumSettings,
$seleniumBrowsers,
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
