http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84469
Revision: 84469
Author: aaron
Date: 2011-03-21 18:37:54 +0000 (Mon, 21 Mar 2011)
Log Message:
-----------
* Make use of log_search table for review log
* Renamed updateLog -> updateReviewLog
Modified Paths:
--------------
trunk/extensions/FlaggedRevs/FlaggedRevs.class.php
trunk/extensions/FlaggedRevs/FlaggedRevsLogs.php
trunk/extensions/FlaggedRevs/forms/RevisionReviewForm.php
Modified: trunk/extensions/FlaggedRevs/FlaggedRevs.class.php
===================================================================
--- trunk/extensions/FlaggedRevs/FlaggedRevs.class.php 2011-03-21 18:21:43 UTC
(rev 84468)
+++ trunk/extensions/FlaggedRevs/FlaggedRevs.class.php 2011-03-21 18:37:54 UTC
(rev 84469)
@@ -1273,7 +1273,7 @@
) );
$flaggedRevision->insertOn( $auto );
# Update the article review log
- FlaggedRevsLogs::updateLog( $title,
+ FlaggedRevsLogs::updateReviewLog( $title,
$flags, array(), '', $rev->getId(), $oldSvId, true,
$auto );
# Update page and tracking tables and clear cache
Modified: trunk/extensions/FlaggedRevs/FlaggedRevsLogs.php
===================================================================
--- trunk/extensions/FlaggedRevs/FlaggedRevsLogs.php 2011-03-21 18:21:43 UTC
(rev 84468)
+++ trunk/extensions/FlaggedRevs/FlaggedRevsLogs.php 2011-03-21 18:37:54 UTC
(rev 84469)
@@ -158,7 +158,7 @@
}
/**
- * Record a log entry on the action
+ * Record a log entry on the review action
* @param Title $title
* @param array $dims
* @param array $oldDims
@@ -168,7 +168,7 @@
* @param bool $approve, approved? (otherwise unapproved)
* @param bool $auto
*/
- public static function updateLog( $title, $dims, $oldDims, $comment,
+ public static function updateReviewLog( $title, $dims, $oldDims,
$comment,
$revId, $stableId, $approve, $auto = false )
{
$log = new LogPage( 'review',
@@ -214,7 +214,9 @@
}
$ts = Revision::getTimestampFromId( $title, $revId );
# Param format is <rev id, old stable id, rev timestamp>
- $log->addEntry( $action, $title, $comment, array( $revId,
$stableId, $ts ) );
+ $logid = $log->addEntry( $action, $title, $comment, array(
$revId, $stableId, $ts ) );
+ # Make log easily searchable by rev_id
+ $log->addRelations( 'rev_id', array( $revId ), $logid );
}
/**
Modified: trunk/extensions/FlaggedRevs/forms/RevisionReviewForm.php
===================================================================
--- trunk/extensions/FlaggedRevs/forms/RevisionReviewForm.php 2011-03-21
18:21:43 UTC (rev 84468)
+++ trunk/extensions/FlaggedRevs/forms/RevisionReviewForm.php 2011-03-21
18:37:54 UTC (rev 84469)
@@ -436,7 +436,7 @@
# Update the article review log...
$oldSvId = $oldSv ? $oldSv->getRevId() : 0;
- FlaggedRevsLogs::updateLog( $this->page, $this->dims,
$this->oflags,
+ FlaggedRevsLogs::updateReviewLog( $this->page, $this->dims,
$this->oflags,
$this->comment, $this->oldid, $oldSvId, true );
# Get the new stable version as of now
@@ -476,7 +476,7 @@
# Update the article review log
$oldSvId = $oldSv ? $oldSv->getRevId() : 0;
- FlaggedRevsLogs::updateLog( $this->page, $this->dims,
$this->oflags,
+ FlaggedRevsLogs::updateReviewLog( $this->page, $this->dims,
$this->oflags,
$this->comment, $this->oldid, $oldSvId, false );
# Get the new stable version as of now
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs