http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84474
Revision: 84474
Author: tparscal
Date: 2011-03-21 18:57:46 +0000 (Mon, 21 Mar 2011)
Log Message:
-----------
* Added error handling on submit failure
* Fixed error display to cover entire UI
Modified Paths:
--------------
trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.css
trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js
Modified:
trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.css
===================================================================
---
trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.css
2011-03-21 18:52:41 UTC (rev 84473)
+++
trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.css
2011-03-21 18:57:46 UTC (rev 84474)
@@ -23,6 +23,7 @@
display: none;
position: absolute;
top: 0;
+ bottom: 0;
left: 0;
right: 0;
background-color: #f9f9f9;
Modified:
trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js
===================================================================
---
trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js
2011-03-21 18:52:41 UTC (rev 84473)
+++
trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js
2011-03-21 18:57:46 UTC (rev 84474)
@@ -142,8 +142,14 @@
} ),
'success': function( data ) {
var context = this;
- $.articleFeedback.fn.load.call( context
);
- context.$ui.find(
'.articleFeedback-lock' ).hide();
+ if ( 'error' in data ) {
+ mw.log( 'Form submission error'
);
+ mw.log( data.error );
+ context.$ui.find(
'.articleFeedback-error' ).show();
+ } else {
+ $.articleFeedback.fn.load.call(
context );
+ context.$ui.find(
'.articleFeedback-lock' ).hide();
+ }
},
'error': function() {
var context = this;
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
