http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84529
Revision: 84529
Author: tparscal
Date: 2011-03-22 14:38:20 +0000 (Tue, 22 Mar 2011)
Log Message:
-----------
* Bucket was set to 0 by default, but API gives warning if bucket is less than
1, now using 1 as default.
* Expiry notice was shown when the form was hidden and then shown because of a
misplaced class - visible-with-form class has been moved to a new surrounding
div so the notice will still show and hide without loosing it's own particular
visibility state.
Modified Paths:
--------------
trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js
Modified:
trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js
===================================================================
---
trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js
2011-03-22 13:59:00 UTC (rev 84528)
+++
trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js
2011-03-22 14:38:20 UTC (rev 84529)
@@ -33,9 +33,11 @@
<button class="articleFeedback-submit
articleFeedback-visibleWith-form" type="submit" disabled><html:msg
key="form-panel-submit" /></button>\
<div class="articleFeedback-success
articleFeedback-visibleWith-form"><span><html:msg key="form-panel-success"
/></span></div>\
<div style="clear:both;"></div>\
- <div class="articleFeedback-expiry
articleFeedback-visibleWith-form">\
- <div class="articleFeedback-expiry-title"><html:msg
key="form-panel-expiry-title" /></div>\
- <div class="articleFeedback-expiry-message"><html:msg
key="form-panel-expiry-message" /></div>\
+ <div class="articleFeedback-notices
articleFeedback-visibleWith-form">\
+ <div class="articleFeedback-expiry">\
+ <div
class="articleFeedback-expiry-title"><html:msg key="form-panel-expiry-title"
/></div>\
+ <div
class="articleFeedback-expiry-message"><html:msg
key="form-panel-expiry-message" /></div>\
+ </div>\
</div>\
</div>\
<div class="articleFeedback-error"><div
class="articleFeedback-error-message"><html:msg key="error" /></div></div>\
@@ -602,7 +604,7 @@
var context = $(this).data( 'articleFeedback-context' );
if ( !context ) {
// Create context
- context = { '$ui': $(this), 'options': { 'ratings': {},
'pitches': {}, 'bucket': 0 } };
+ context = { '$ui': $(this), 'options': { 'ratings': {},
'pitches': {}, 'bucket': 1 } };
// Allow customization through an options argument
if ( typeof args[0] === 'object' ) {
context = $.extend( true, context, { 'options':
args[0] } );
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
