http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84598
Revision: 84598
Author: aaron
Date: 2011-03-23 16:01:34 +0000 (Wed, 23 Mar 2011)
Log Message:
-----------
Fixed reparse bug in buildQuickReview() due to comparison weakness
Modified Paths:
--------------
trunk/extensions/FlaggedRevs/forms/RevisionReviewForm.php
Modified: trunk/extensions/FlaggedRevs/forms/RevisionReviewForm.php
===================================================================
--- trunk/extensions/FlaggedRevs/forms/RevisionReviewForm.php 2011-03-23
15:14:44 UTC (rev 84597)
+++ trunk/extensions/FlaggedRevs/forms/RevisionReviewForm.php 2011-03-23
16:01:34 UTC (rev 84598)
@@ -642,7 +642,7 @@
*/
public static function buildQuickReview(
User $user, FlaggedArticle $article, Revision $rev,
- $refId = 0, $topNotice = '', $templateIDs, $imageSHA1Keys
+ $refId = 0, $topNotice = '', array $templateIDs = null, array
$imageSHA1Keys = null
) {
global $wgOut, $wgLang, $wgParser, $wgEnableParserCache;
$id = $rev->getId();
@@ -745,7 +745,7 @@
}
# Do we need to get inclusion IDs from parser output?
- if ( !$templateIDs || !$imageSHA1Keys ) {
+ if ( $templateIDs === null || $imageSHA1Keys === null ) {
$pOutput = false;
# Current version: try parser cache
if ( $rev->isCurrent() ) {
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
