http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84609
Revision: 84609
Author: maxsem
Date: 2011-03-23 17:29:22 +0000 (Wed, 23 Mar 2011)
Log Message:
-----------
Tweaks for r84594:
* Made Tipsy a dependency instead of making another request to load it
programmatically
* Made it available everywhere in Special:Code, not just in revision lists.
Ideally, it should be available on every pageview to improve links to revisions
from ordinary wiki pages.
Modified Paths:
--------------
trunk/extensions/CodeReview/CodeReview.php
trunk/extensions/CodeReview/modules/ext.codereview.tooltips.js
trunk/extensions/CodeReview/ui/CodeRevisionListView.php
trunk/extensions/CodeReview/ui/SpecialCode.php
Modified: trunk/extensions/CodeReview/CodeReview.php
===================================================================
--- trunk/extensions/CodeReview/CodeReview.php 2011-03-23 17:19:43 UTC (rev
84608)
+++ trunk/extensions/CodeReview/CodeReview.php 2011-03-23 17:29:22 UTC (rev
84609)
@@ -151,7 +151,8 @@
// Revision tooltips CodeRevisionView:
$wgResourceModules['ext.codereview.tooltips'] = array(
- 'scripts' => 'ext.codereview.tooltips.js'
+ 'scripts' => 'ext.codereview.tooltips.js',
+ 'dependencies' => 'jquery.tipsy'
) + $commonModuleInfo;
// If you are running a closed svn, fill the following two lines with the
username and password
Modified: trunk/extensions/CodeReview/modules/ext.codereview.tooltips.js
===================================================================
--- trunk/extensions/CodeReview/modules/ext.codereview.tooltips.js
2011-03-23 17:19:43 UTC (rev 84608)
+++ trunk/extensions/CodeReview/modules/ext.codereview.tooltips.js
2011-03-23 17:29:22 UTC (rev 84609)
@@ -48,6 +48,4 @@
});
};
-mw.loader.using( 'jquery.tipsy', function(){
- $( document ).ready( CodeTooltipsInit );
-});
+$( document ).ready( CodeTooltipsInit );
Modified: trunk/extensions/CodeReview/ui/CodeRevisionListView.php
===================================================================
--- trunk/extensions/CodeReview/ui/CodeRevisionListView.php 2011-03-23
17:19:43 UTC (rev 84608)
+++ trunk/extensions/CodeReview/ui/CodeRevisionListView.php 2011-03-23
17:29:22 UTC (rev 84609)
@@ -78,8 +78,6 @@
$navBar = $pager->getNavigationBar();
- $wgOut->addModules( 'ext.codereview.tooltips' );
-
$wgOut->addHTML( $pathForm );
$wgOut->addHTML(
Modified: trunk/extensions/CodeReview/ui/SpecialCode.php
===================================================================
--- trunk/extensions/CodeReview/ui/SpecialCode.php 2011-03-23 17:19:43 UTC
(rev 84608)
+++ trunk/extensions/CodeReview/ui/SpecialCode.php 2011-03-23 17:29:22 UTC
(rev 84609)
@@ -19,6 +19,7 @@
$this->setHeaders();
// Base styles used for all code review UI actions.
$wgOut->addModules( 'ext.codereview' );
+ $wgOut->addModules( 'ext.codereview.tooltips' );
$view = $this->getViewFrom( $subpage );
if( $view ) {
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
