http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88130

Revision: 88130
Author:   catrope
Date:     2011-05-14 23:49:29 +0000 (Sat, 14 May 2011)
Log Message:
-----------
Kill diff.js with fire. It only applies to versions of Gecko that were released 
before Nov 2002, which is waaaay beyond what we support, or what anyone could 
conceivably be using in this day and age.

Modified Paths:
--------------
    trunk/phase3/includes/diff/DifferenceEngine.php
    trunk/phase3/resources/Resources.php

Removed Paths:
-------------
    trunk/phase3/skins/common/diff.js

Modified: trunk/phase3/includes/diff/DifferenceEngine.php
===================================================================
--- trunk/phase3/includes/diff/DifferenceEngine.php     2011-05-14 23:48:59 UTC 
(rev 88129)
+++ trunk/phase3/includes/diff/DifferenceEngine.php     2011-05-14 23:49:29 UTC 
(rev 88130)
@@ -645,7 +645,6 @@
        function showDiffStyle() {
                global $wgOut;
                $wgOut->addModuleStyles( 'mediawiki.legacy.diff' );
-               $wgOut->addModuleScripts( 'mediawiki.legacy.diff' );
        }
 
        /**

Modified: trunk/phase3/resources/Resources.php
===================================================================
--- trunk/phase3/resources/Resources.php        2011-05-14 23:48:59 UTC (rev 
88129)
+++ trunk/phase3/resources/Resources.php        2011-05-14 23:49:29 UTC (rev 
88130)
@@ -594,13 +594,10 @@
                'dependencies' => 'mediawiki.legacy.wikibits',
        ),
        'mediawiki.legacy.diff' => array(
-               'scripts' => 'common/diff.js',
                'styles' => 'common/diff.css',
                'group' => 'mediawiki.action.history',
                'remoteBasePath' => $GLOBALS['wgStylePath'],
                'localBasePath' => "{$GLOBALS['IP']}/skins",
-               'dependencies' => 'mediawiki.legacy.wikibits',
-               'position' => 'top',
        ),
        'mediawiki.legacy.edit' => array(
                'scripts' => 'common/edit.js',

Deleted: trunk/phase3/skins/common/diff.js
===================================================================
--- trunk/phase3/skins/common/diff.js   2011-05-14 23:48:59 UTC (rev 88129)
+++ trunk/phase3/skins/common/diff.js   2011-05-14 23:49:29 UTC (rev 88130)
@@ -1,20 +0,0 @@
-/*
-Workaround for overflow bug in Mozilla 1.1 and earlier, where scrolling
-<div>s in <td> cells collapse their height to a single line.
-
-Known to be fixed in 1.2.1 (Gecko 20021130), but the CSS hacks I've tried
-with overflow-x disable the scrolling all the way until Mozilla 1.8 / FF 1.5
-and break Opera as well.
-
-So... we check for reaaaally old Gecko and hack in an alternate rule to let
-the wide cells spill instead of scrolling them. Not ideal as it won't work
-if JS is disabled, of course.
-*/
-
-if (navigator && navigator.product == "Gecko" && navigator.productSub < 
"20021130") {
-       var sheets = document.styleSheets;
-       var lastSheet = sheets[sheets.length-1];
-       lastSheet.insertRule(
-               "table.diff td div { overflow: visible; }",
-               lastSheet.cssRules.length);
-}


_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to