http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88151
Revision: 88151
Author: erik
Date: 2011-05-15 11:01:27 +0000 (Sun, 15 May 2011)
Log Message:
-----------
Move to startup per r88146 code review comment
Modified Paths:
--------------
trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js
trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.startup.js
Modified:
trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js
===================================================================
---
trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js
2011-05-15 10:57:01 UTC (rev 88150)
+++
trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js
2011-05-15 11:01:27 UTC (rev 88151)
@@ -310,9 +310,6 @@
}
};
-// Do not show if we're viewing a redirect
-if(mw.util.getParamValue('redirect')=='no') return false;
-
/* Load at the bottom of the article */
var $aftDiv = $( '<div id="mw-articlefeedback"></div>' ).articleFeedback(
config );
Modified:
trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.startup.js
===================================================================
---
trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.startup.js
2011-05-15 10:57:01 UTC (rev 88150)
+++
trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.startup.js
2011-05-15 11:01:27 UTC (rev 88151)
@@ -13,6 +13,8 @@
// Current revision
&& mw.util.getParamValue( 'diff' ) == null
&& mw.util.getParamValue( 'oldid' ) == null
+ // Not viewing a redirect
+ && mw.util.getParamValue( 'redirect' ) != 'no'
) {
var trackingBucket = mw.user.bucket(
'ext.articleFeedback-tracking', mw.config.get(
'wgArticleFeedbackTracking' )
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
