http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88551
Revision: 88551
Author: reedy
Date: 2011-05-21 22:44:48 +0000 (Sat, 21 May 2011)
Log Message:
-----------
* (bug 26240) CodeReview's (partially absence of) query params suck (tracking)
Make filtering by author/status work for each other when using the main list
view
$suckage--;
Modified Paths:
--------------
trunk/extensions/CodeReview/ui/CodeRevisionListView.php
Modified: trunk/extensions/CodeReview/ui/CodeRevisionListView.php
===================================================================
--- trunk/extensions/CodeReview/ui/CodeRevisionListView.php 2011-05-21
22:32:04 UTC (rev 88550)
+++ trunk/extensions/CodeReview/ui/CodeRevisionListView.php 2011-05-21
22:44:48 UTC (rev 88551)
@@ -24,6 +24,7 @@
}
$this->mAuthor = $wgRequest->getText( 'author' );
+ $this->mStatus = $wgRequest->getText( 'status' );
$this->mAppliedFilter = null;
}
@@ -348,14 +349,22 @@
$pathQuery
);
case 'cr_status':
+ $options = $pathQuery;
+ if ( $this->mView->mAuthor ) {
+ $options['author'] = $this->mView->mAuthor;
+ }
return $this->mView->skin->link(
SpecialPage::getTitleFor( 'Code',
$this->mRepo->getName() . '/status/' . $value ),
htmlspecialchars( $this->mView->statusDesc(
$value ) ),
array(),
- $pathQuery
+ $options
);
case 'cr_author':
- return $this->mView->authorLink( $value, $pathQuery );
+ $options = $pathQuery;
+ if ( $this->mView->mStatus ) {
+ $options['status'] = $this->mView->mStatus;
+ }
+ return $this->mView->authorLink( $value, $options );
case 'cr_message':
return $this->mView->messageFragment( $value );
case 'cr_timestamp':
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
