http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88556

Revision: 88556
Author:   reedy
Date:     2011-05-21 23:34:22 +0000 (Sat, 21 May 2011)
Log Message:
-----------
* (bug 26240) CodeReview's (partially absence of) query params suck (tracking)

$suckage--;

Switch default list view to use query params, rather than all the /foo/bar, 
they are kept around for pretty links

Modified Paths:
--------------
    trunk/extensions/CodeReview/ui/CodeRevisionListView.php

Modified: trunk/extensions/CodeReview/ui/CodeRevisionListView.php
===================================================================
--- trunk/extensions/CodeReview/ui/CodeRevisionListView.php     2011-05-21 
23:22:47 UTC (rev 88555)
+++ trunk/extensions/CodeReview/ui/CodeRevisionListView.php     2011-05-21 
23:34:22 UTC (rev 88556)
@@ -353,8 +353,9 @@
                        if ( $this->mView->mAuthor ) {
                                $options['author'] = $this->mView->mAuthor;
                        }
+                       $options['status'] = $value;
                        return $this->mView->skin->link(
-                               SpecialPage::getTitleFor( 'Code', 
$this->mRepo->getName() . '/status/' . $value ),
+                               SpecialPage::getTitleFor( 'Code', 
$this->mRepo->getName() ),
                                htmlspecialchars( $this->mView->statusDesc( 
$value ) ),
                                array(),
                                $options
@@ -364,7 +365,13 @@
                        if ( $this->mView->mStatus ) {
                                $options['status'] = $this->mView->mStatus;
                        }
-                       return $this->mView->authorLink( $value, $options );
+                       $options['author'] = $value;
+                       return $this->mView->skin->link(
+                               SpecialPage::getTitleFor( 'Code', 
$this->mRepo->getName() ),
+                               htmlspecialchars( $value ),
+                               array(),
+                               $options
+                       );
                case 'cr_message':
                        return $this->mView->messageFragment( $value );
                case 'cr_timestamp':


_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to