http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89182
Revision: 89182
Author: hashar
Date: 2011-05-30 18:58:07 +0000 (Mon, 30 May 2011)
Log Message:
-----------
add broken test to broken group (not incomplete)
This test suite really needs to be fixed, marking them as incomplete does not
let us tests them easily. Instead, I have added them to the Broken group thus
we can easily run them and do not break the continuous integration system.
Modified Paths:
--------------
trunk/phase3/tests/phpunit/includes/api/ApiWatchTest.php
Modified: trunk/phase3/tests/phpunit/includes/api/ApiWatchTest.php
===================================================================
--- trunk/phase3/tests/phpunit/includes/api/ApiWatchTest.php 2011-05-30
18:40:27 UTC (rev 89181)
+++ trunk/phase3/tests/phpunit/includes/api/ApiWatchTest.php 2011-05-30
18:58:07 UTC (rev 89182)
@@ -5,6 +5,7 @@
/**
* @group Database
* @group Destructive
+ * @todo This test suite is severly broken and need a full review
*/
class ApiWatchTest extends ApiTestSetup {
@@ -17,11 +18,13 @@
return $this->getTokenList( $this->sysopUser );
}
+ /**
+ * @group Broken
+ */
function testWatchEdit() {
$data = $this->getTokens();
- $this->markTestIncomplete( "Broken" );
$keys = array_keys( $data[0]['query']['pages'] );
$key = array_pop( $keys );
$pageinfo = $data[0]['query']['pages'][$key];
@@ -68,12 +71,13 @@
return $data;
}
-
+ /**
+ * @group Broken
+ */
function testWatchProtect() {
$data = $this->getTokens();
- $this->markTestIncomplete( "Broken" );
$keys = array_keys( $data[0]['query']['pages'] );
$key = array_pop( $keys );
$pageinfo = $data[0]['query']['pages'][$key];
@@ -125,6 +129,7 @@
/**
* @depends testGetRollbackToken
+ * @group Broken
*/
function testWatchRollback( $data ) {
$keys = array_keys( $data[0]['query']['pages'] );
@@ -142,7 +147,7 @@
if( $ue->getCodeString() == 'onlyauthor' ) {
$this->markTestIncomplete( "Only one author to
'UTPage', cannot test rollback" );
} else {
- $this->fail( "Received error " .
$ue->getCodeString() );
+ $this->fail( "Received error '" .
$ue->getCodeString() . "'" );
}
}
@@ -150,12 +155,13 @@
$this->assertArrayHasKey( 'title', $data[0]['rollback'] );
}
-
+ /**
+ * @group Broken
+ */
function testWatchDelete() {
$data = $this->getTokens();
- $this->markTestIncomplete( "Broken" );
$keys = array_keys( $data[0]['query']['pages'] );
$key = array_pop( $keys );
$pageinfo = $data[0]['query']['pages'][$key];
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
