http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89247
Revision: 89247
Author: brion
Date: 2011-06-01 01:24:45 +0000 (Wed, 01 Jun 2011)
Log Message:
-----------
Follow-up to r89243 to fix the async qunit test
Per CR & IRC discussion; added the missing stop() & start() calls, and using
the timeout parameter for stop() so we can actually detect the regression
(original bug caused neither the success nor failure callbacks to fire, so the
test runner would just stop)
Modified Paths:
--------------
trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.js
Modified: trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.js
===================================================================
--- trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.js
2011-06-01 01:10:09 UTC (rev 89246)
+++ trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.js
2011-06-01 01:24:45 UTC (rev 89247)
@@ -176,8 +176,13 @@
test( 'mw.loader.bug29107' , function() {
expect( 1 );
+ // Async! Include a timeout, as failure on this bug lead to neither the
+ // success nor failure callbacks getting called.
+ stop(1500);
+
mw.loader.implement( 'bug29107.messages-only', [], {}, {'bug29107':
'loaded'} );
mw.loader.using( 'bug29107.messages-only', function() {
+ start();
ok( mw.messages.exists( 'bug29107' ), 'Bug 29107: messages-only
module should load ok' );
}, function(){
start();
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
