http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89274

Revision: 89274
Author:   tparscal
Date:     2011-06-01 17:34:33 +0000 (Wed, 01 Jun 2011)
Log Message:
-----------
Fixes bug #29222  by conditionally adding the clicktracking parameters to the 
returnto URL.

Modified Paths:
--------------
    
trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js

Modified: 
trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js
===================================================================
--- 
trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js
 2011-06-01 16:40:59 UTC (rev 89273)
+++ 
trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js
 2011-06-01 17:34:33 UTC (rev 89274)
@@ -290,15 +290,20 @@
                        'action': function() {
                                // Mute for 7 days
                                mutePitch( 'edit', 7 );
-                               // Go to edit page
-                               // Track the click through an API redirect
+                               // Setup edit page link
+                               var params = {
+                                       'title': mw.config.get( 'wgPageName' ),
+                                       'action': 'edit'
+                               };
+                               if ( tracked ) {
+                                       // Keep track of tracked users' edits
+                                       params.clicktrackingsession = $.cookie( 
'clicktracking-session' );
+                                       params.clicktrackingevent = prefix( 
'pitch-edit-save' );
+                               }
+                               // Track the click through an API redirect 
(automatically bypasses if !tracked)
                                window.location = trackClickURL(
-                                       mw.config.get( 'wgScript' ) + '?' + 
$.param( {
-                                               'title': mw.config.get( 
'wgPageName' ),
-                                               'action': 'edit',
-                                               'clicktrackingsession': 
$.cookie( 'clicktracking-session' ),
-                                               'clicktrackingevent': prefix( 
'pitch-edit-save' )
-                                       } ), 'pitch-edit-accept' );
+                                       mw.config.get( 'wgScript' ) + '?' + 
$.param( params ), 'pitch-edit-accept'
+                               );
                                return false;
                        },
                        'title': 'articlefeedback-pitch-thanks',


_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to