http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89300
Revision: 89300
Author: brion
Date: 2011-06-01 22:35:03 +0000 (Wed, 01 Jun 2011)
Log Message:
-----------
Add some doc comments on Cookie::validateCookieDomain() and Http::isValidUri(),
which both have some failing test cases and are incomplete
Modified Paths:
--------------
trunk/phase3/includes/Cookie.php
trunk/phase3/includes/HttpFunctions.php
Modified: trunk/phase3/includes/Cookie.php
===================================================================
--- trunk/phase3/includes/Cookie.php 2011-06-01 22:27:24 UTC (rev 89299)
+++ trunk/phase3/includes/Cookie.php 2011-06-01 22:35:03 UTC (rev 89300)
@@ -62,6 +62,9 @@
* A better method might be to use a blacklist like
* http://publicsuffix.org/
*
+ * @fixme fails to detect 3-letter top-level domains
+ * @fixme fails to detect 2-letter top-level domains for single-domain
use (probably not a big problem in practice, but there are test cases)
+ *
* @param $domain String: the domain to validate
* @param $originDomain String: (optional) the domain the cookie
originates from
* @return Boolean
Modified: trunk/phase3/includes/HttpFunctions.php
===================================================================
--- trunk/phase3/includes/HttpFunctions.php 2011-06-01 22:27:24 UTC (rev
89299)
+++ trunk/phase3/includes/HttpFunctions.php 2011-06-01 22:35:03 UTC (rev
89300)
@@ -125,6 +125,9 @@
* protocols, because we only want protocols that both cURL
* and php support.
*
+ * @fixme this is wildly inaccurate and fails to actually check most
stuff
+ * @fixme do we actually intend to have FTP support here? Does it work
consistently?
+ *
* @param $uri Mixed: URI to check for validity
* @returns Boolean
*/
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
