http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89642
Revision: 89642
Author: reedy
Date: 2011-06-07 11:34:47 +0000 (Tue, 07 Jun 2011)
Log Message:
-----------
* (bug 29297) 'Strike selected sign-offs' shouldn't appear if there are no
sign-offs
Modified Paths:
--------------
trunk/extensions/CodeReview/ui/CodeRevisionView.php
Modified: trunk/extensions/CodeReview/ui/CodeRevisionView.php
===================================================================
--- trunk/extensions/CodeReview/ui/CodeRevisionView.php 2011-06-07 09:49:43 UTC
(rev 89641)
+++ trunk/extensions/CodeReview/ui/CodeRevisionView.php 2011-06-07 11:34:47 UTC
(rev 89642)
@@ -764,7 +764,9 @@
*/
protected function signoffButtons( $signOffs ) {
$userSignOffs = $this->getUserSignoffs( $signOffs );
- $strikeButton = Xml::submitButton( wfMsg( 'code-signoff-strike'
), array( 'name' => 'wpStrikeSignoffs' ) );
+ $strikeButton = count( $userSignOffs )
+ ? Xml::submitButton( wfMsg( 'code-signoff-strike' ),
array( 'name' => 'wpStrikeSignoffs' ) )
+ : '';
$signoffText = wfMsgHtml( 'code-signoff-signoff' );
$signoffButton = Xml::submitButton( wfMsg(
'code-signoff-submit' ), array( 'name' => 'wpSignoff' ) );
$checks = '';
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
