http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89668
Revision: 89668
Author: demon
Date: 2011-06-07 18:13:21 +0000 (Tue, 07 Jun 2011)
Log Message:
-----------
Fix (Api)BlockTest for Sqlite. getRangeStart()/getRangeEnd() were returning
null for user blocks, which was then happily inserted into a NOT NULL column.
The IGNORE was just masking the real error. Thanks Brion and MaxSem. Oh, and
ping r84475
Modified Paths:
--------------
trunk/phase3/includes/Block.php
Modified: trunk/phase3/includes/Block.php
===================================================================
--- trunk/phase3/includes/Block.php 2011-06-07 18:04:12 UTC (rev 89667)
+++ trunk/phase3/includes/Block.php 2011-06-07 18:13:21 UTC (rev 89668)
@@ -703,7 +703,7 @@
public function getRangeStart() {
switch( $this->type ) {
case self::TYPE_USER:
- return null;
+ return '';
case self::TYPE_IP:
return IP::toHex( $this->target );
case self::TYPE_RANGE:
@@ -720,7 +720,7 @@
public function getRangeEnd() {
switch( $this->type ) {
case self::TYPE_USER:
- return null;
+ return '';
case self::TYPE_IP:
return IP::toHex( $this->target );
case self::TYPE_RANGE:
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
