http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89790
Revision: 89790
Author: ialex
Date: 2011-06-09 19:52:07 +0000 (Thu, 09 Jun 2011)
Log Message:
-----------
Removed some usage of error suppression operator
Modified Paths:
--------------
trunk/phase3/includes/ConfEditor.php
trunk/phase3/includes/HistoryBlob.php
Modified: trunk/phase3/includes/ConfEditor.php
===================================================================
--- trunk/phase3/includes/ConfEditor.php 2011-06-09 19:45:10 UTC (rev
89789)
+++ trunk/phase3/includes/ConfEditor.php 2011-06-09 19:52:07 UTC (rev
89790)
@@ -315,7 +315,7 @@
// extra quote on the end!
return strtr( substr( trim( $str ), 1, -1 ),
array( '\\\'' => '\'', '\\\\' => '\\' ) );
- if ( $str !== '' && @$str[0] == '"' )
+ if ( $str !== '' && $str[0] == '"' )
// Double-quoted string
// @todo FIXME: trim() call is due to mystery bug where
whitespace gets
// appended to the token; without it we ended up
reading in the
Modified: trunk/phase3/includes/HistoryBlob.php
===================================================================
--- trunk/phase3/includes/HistoryBlob.php 2011-06-09 19:45:10 UTC (rev
89789)
+++ trunk/phase3/includes/HistoryBlob.php 2011-06-09 19:52:07 UTC (rev
89790)
@@ -225,8 +225,8 @@
$flags = explode( ',', $row->old_flags );
if( in_array( 'external', $flags ) ) {
$url=$row->old_text;
- @list( /* $proto */
,$path)=explode('://',$url,2);
- if ( $path == "" ) {
+ $parts = explode( '://', $url, 2 );
+ if ( !isset( $parts[1] ) || $parts[1] == '' ) {
wfProfileOut( $fname );
return false;
}
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
