http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89946

Revision: 89946
Author:   happydog
Date:     2011-06-13 06:56:19 +0000 (Mon, 13 Jun 2011)
Log Message:
-----------
[CodeReview] Follow-up to r89187.  The start argument makes no sense when 'all' 
is being used, so we ignore it in that case (as per the argument description).

Modified Paths:
--------------
    trunk/extensions/CodeReview/svnImport.php

Modified: trunk/extensions/CodeReview/svnImport.php
===================================================================
--- trunk/extensions/CodeReview/svnImport.php   2011-06-13 03:43:31 UTC (rev 
89945)
+++ trunk/extensions/CodeReview/svnImport.php   2011-06-13 06:56:19 UTC (rev 
89946)
@@ -33,19 +33,18 @@
                        }
                }
 
-               $startRev = null;
-               if ( $this->hasArg( 1 ) ) {
-                       $startRev = $this->getArg( 1 );
-               }
-
                $repo = $this->getArg( 0 );
 
                if ( $repo == "all" ) {
                        $repoList = CodeRepository::getRepoList();
                        foreach ( $repoList as $repoInfo ) {
-                               $this->importRepo( $repoInfo->getName(), 
$startRev, $cacheSize );
+                               $this->importRepo( $repoInfo->getName(), null, 
$cacheSize );
                        }
                } else {
+                       $startRev = null;
+                       if ( $this->hasArg( 1 ) ) {
+                               $startRev = $this->getArg( 1 );
+                       }
                        $this->importRepo( $repo, $startRev, $cacheSize );
                }
        }


_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to