http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90530
Revision: 90530
Author: platonides
Date: 2011-06-21 15:06:59 +0000 (Tue, 21 Jun 2011)
Log Message:
-----------
Revert r90483, if tesla has problems, it should get proper permissions to the
affected folders (or change the test to use a temp folder)
The test was not consistent, since first time it would use the svn file, which
renames it... and on next run it would be missing!
I added the '.' to the unlik() step so it properly cleans up. Opened bug 29512
for the strange UploadStash behavior.
However, although it passes now most of the times, it sometimes fails with the
strange exception:
Only variables should be passed by reference
phase3/includes/upload/UploadStash.php:143
phase3/tests/phpunit/includes/upload/UploadStashTest.php:22
phase3/tests/phpunit/MediaWikiTestCase.php:64
phase3/tests/phpunit/MediaWikiPHPUnitCommand.php:20
phase3/tests/phpunit/phpunit.php:60
Modified Paths:
--------------
trunk/phase3/tests/phpunit/includes/upload/UploadStashTest.php
Removed Paths:
-------------
trunk/phase3/tests/phpunit/includes/upload/bug29408
Modified: trunk/phase3/tests/phpunit/includes/upload/UploadStashTest.php
===================================================================
--- trunk/phase3/tests/phpunit/includes/upload/UploadStashTest.php
2011-06-21 15:01:45 UTC (rev 90529)
+++ trunk/phase3/tests/phpunit/includes/upload/UploadStashTest.php
2011-06-21 15:06:59 UTC (rev 90530)
@@ -11,7 +11,7 @@
// Setup a file for bug 29408
$this->bug29408File = dirname( __FILE__ ) . '/bug29408';
- // file_put_contents( $this->bug29408File, "\x00" );
+ file_put_contents( $this->bug29408File, "\x00" );
}
public function testBug29408() {
@@ -28,5 +28,8 @@
public function tearDown() {
parent::tearDown();
+
+ unlink( $this->bug29408File . "." );
+
}
-}
\ No newline at end of file
+}
Deleted: trunk/phase3/tests/phpunit/includes/upload/bug29408
===================================================================
(Binary files differ)
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
