http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90748

Revision: 90748
Author:   aaron
Date:     2011-06-25 01:46:43 +0000 (Sat, 25 Jun 2011)
Log Message:
-----------
* Fixed formatPathLine() to account for strtolower() on $action, broken since 
r85671
* Also made formatPathLine() link to the last rev for deleted files instead of 
giving a disabled link

Modified Paths:
--------------
    trunk/extensions/CodeReview/ui/CodeRevisionView.php

Modified: trunk/extensions/CodeReview/ui/CodeRevisionView.php
===================================================================
--- trunk/extensions/CodeReview/ui/CodeRevisionView.php 2011-06-25 01:43:24 UTC 
(rev 90747)
+++ trunk/extensions/CodeReview/ui/CodeRevisionView.php 2011-06-25 01:46:43 UTC 
(rev 90748)
@@ -288,14 +288,20 @@
                if ( $viewvc ) {
                        $rev = $this->mRev->getId();
                        $prev = $rev - 1;
-                       if ( $action !== 'D' ) {
+                       if ( $action === 'd' ) {
+                               if ( $rev > 1 ) {
+                                       $link = $this->skin->makeExternalLink( 
// last rev
+                                               
"{$viewvc}{$safePath}?view=markup&pathrev=".($rev-1),
+                                               $path . $from );
+                               } else {
+                                       $link = $safePath; // imported to SVN 
or something
+                               }
+                       } else {
                                $link = $this->skin->makeExternalLink(
-                                       
"$viewvc$safePath?view=markup&pathrev=$rev",
+                                       
"{$viewvc}{$safePath}?view=markup&pathrev=$rev",
                                        $path . $from );
-                       } else {
-                               $link = $safePath;
                        }
-                       if ( $action !== 'A' && $action !== 'D' ) {
+                       if ( $action !== 'a' && $action !== 'd' ) {
                                $diff = ' (' .
                                        $this->skin->makeExternalLink(
                                                
"$viewvc$safePath?&pathrev=$rev&r1=$prev&r2=$rev",


_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to