http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90893
Revision: 90893
Author: happy-melon
Date: 2011-06-27 17:49:30 +0000 (Mon, 27 Jun 2011)
Log Message:
-----------
Follow-up r86490 CR: localise strings and synchronise CSS styles.
Modified Paths:
--------------
trunk/extensions/CodeReview/CodeReview.i18n.php
trunk/extensions/CodeReview/CodeReview.php
trunk/extensions/CodeReview/modules/ext.codereview.overview.css
trunk/extensions/CodeReview/modules/ext.codereview.overview.js
Modified: trunk/extensions/CodeReview/CodeReview.i18n.php
===================================================================
--- trunk/extensions/CodeReview/CodeReview.i18n.php 2011-06-27 17:44:15 UTC
(rev 90892)
+++ trunk/extensions/CodeReview/CodeReview.i18n.php 2011-06-27 17:49:30 UTC
(rev 90893)
@@ -142,6 +142,9 @@
'codereview-reply-link' => 'reply',
+ 'codereview-overview-title' => 'Overview',
+ 'codereview-overview-desc' => 'Show a graphical overview of this list',
+
'codereview-email-subj' => '[$1 $2]: New comment added',
'codereview-email-body' => 'User "$1" posted a comment on $3.
Modified: trunk/extensions/CodeReview/CodeReview.php
===================================================================
--- trunk/extensions/CodeReview/CodeReview.php 2011-06-27 17:44:15 UTC (rev
90892)
+++ trunk/extensions/CodeReview/CodeReview.php 2011-06-27 17:49:30 UTC (rev
90893)
@@ -175,7 +175,8 @@
$wgResourceModules['ext.codereview.overview'] = array(
'scripts' => 'ext.codereview.overview.js',
'styles' => 'ext.codereview.overview.css',
- 'dependencies' => 'jquery.tipsy'
+ 'dependencies' => 'jquery.tipsy',
+ 'messages' => array( 'codereview-overview-title',
'codereview-overview-desc' ),
) + $commonModuleInfo;
// If you are running a closed svn, fill the following two lines with the
username and password
Modified: trunk/extensions/CodeReview/modules/ext.codereview.overview.css
===================================================================
--- trunk/extensions/CodeReview/modules/ext.codereview.overview.css
2011-06-27 17:44:15 UTC (rev 90892)
+++ trunk/extensions/CodeReview/modules/ext.codereview.overview.css
2011-06-27 17:49:30 UTC (rev 90893)
@@ -3,7 +3,7 @@
padding: 2px;
min-width: 300px;
}
-#overviewmap #overviewpop {
+#overviewpop {
padding: 3px;
border: 1px solid black;
position: absolute;
@@ -32,38 +32,6 @@
clear: both;
}
-/** Revision statuses **/
-.box-status-new {
- background: #ffffc0 !important;
-}
-.box-status-new:hover {
- background: #dfdfa0 !important;
-}
-.box-status-fixme {
- background: #ff9999 !important;
-}
-.box-status-fixme:hover {
- background: #df0000 !important;
-}
-.box-status-resolved {
- background: #b0eeb0 !important;
-}
-.box-status-resolved:hover {
- background: #80ff80 !important;
-}
-.box-status-reverted {
- background: #bbddee !important;
-}
-.box-status-reverted:hover {
- background: #66bbff !important;
-}
-.box-status-deferred {
- background: #dddddd !important;
-}
-.box-status-deferred:hover {
- background: #aaaaaa !important;
-}
-
table.TablePager tr:target {
font-weight: bold;
}
@@ -75,4 +43,4 @@
tr:target .overview-backlink {
display: inline;
-}
+}
\ No newline at end of file
Modified: trunk/extensions/CodeReview/modules/ext.codereview.overview.js
===================================================================
--- trunk/extensions/CodeReview/modules/ext.codereview.overview.js
2011-06-27 17:44:15 UTC (rev 90892)
+++ trunk/extensions/CodeReview/modules/ext.codereview.overview.js
2011-06-27 17:49:30 UTC (rev 90893)
@@ -15,11 +15,9 @@
mw.util.addPortletLink(
portlet,
'#',
- 'Overview',
+ mw.msg( 'codereview-overview-title' ),
'ca-scapmap',
- 'Show a graphical overview of this list.',
- '1',
- '' // Nextnode, needs to be defined but we
actually don't care
+ mw.msg( 'codereview-overview-desc' )
);
}
@@ -43,9 +41,11 @@
$tr.each( function( i ){
var status = false;
- var trc = $(this).attr( 'class' ).split(' ');
- if( !trc.length ) {
+ var trc = $(this).attr( 'class' );
+ if( !trc || !trc.length ) {
return;
+ } else {
+ trc = trc.split( ' ' );
}
for( var j = 0; j < trc.length; j++ ) {
if( trc[j].substring( 0, 21 ) ==
'mw-codereview-status-' ) {
@@ -78,7 +78,6 @@
if( !totals[statusname] ) {
totals[statusname] = 0;
}
-
totals[statusname]++;
$(this).attr( 'id', 'TablePager-row-' + rev );
@@ -86,7 +85,7 @@
$td.filter( '.TablePager_col_selectforchange' )
.append( $( '<a href="#box-' + i + '"
class="overview-backlink">^</a>' ) );
- var $box = $( '<a href="#TablePager-row-' + rev + '"
class="box-status-' + status + '" id="box-' + i + '"> </a>' );
+ var $box = $( '<a href="#TablePager-row-' + rev + '"
class="mw-codereview-status-' + status + '" id="box-' + i + '"> </a>' );
$( '#overviewmap' ).append( $box );
});
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
