http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96613
Revision: 96613
Author: demon
Date: 2011-09-08 20:17:31 +0000 (Thu, 08 Sep 2011)
Log Message:
-----------
Fix XSS pointed out in r86105
Modified Paths:
--------------
trunk/extensions/FileAttach/FileAttach.php
Modified: trunk/extensions/FileAttach/FileAttach.php
===================================================================
--- trunk/extensions/FileAttach/FileAttach.php 2011-09-08 20:12:43 UTC (rev
96612)
+++ trunk/extensions/FileAttach/FileAttach.php 2011-09-08 20:17:31 UTC (rev
96613)
@@ -70,9 +70,11 @@
# Modify the upload form
if( self::$uploadForm ) {
global $wgRequest;
- if( $attachto = $wgRequest->getText( 'attachto' ) ) {
+ $attachto = $wgRequest->getText( 'attachto' );
+ if( $attachto ) {
$out->mPagetitle = wfMsg(
'fileattach-uploadheading', $attachto );
- $out->mBodytext = str_replace( "</form>",
"<input type=\"hidden\" name=\"attachto\" value=\"$attachto\" /></form>",
$out->mBodytext );
+ $escVal = htmlspecialchars( $attachto );
+ $out->mBodytext = str_replace( "</form>",
"<input type=\"hidden\" name=\"attachto\" value=\"$escVal\" /></form>",
$out->mBodytext );
}
}
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
