http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96667
Revision: 96667
Author: dantman
Date: 2011-09-09 15:37:20 +0000 (Fri, 09 Sep 2011)
Log Message:
-----------
Add a class to the normal and hidden categories blocks. If non-positioning
styles are going to be applied then they should be applied on classes, not ids.
It's bad enough that we include a catlinks id in catlinks and make the process
to attempt to have two catlinks blocks rediculous.
Modified Paths:
--------------
trunk/phase3/includes/Skin.php
Modified: trunk/phase3/includes/Skin.php
===================================================================
--- trunk/phase3/includes/Skin.php 2011-09-09 15:01:50 UTC (rev 96666)
+++ trunk/phase3/includes/Skin.php 2011-09-09 15:37:20 UTC (rev 96667)
@@ -414,7 +414,7 @@
$t = $embed . implode( "{$pop}{$embed}" ,
$allCats['normal'] ) . $pop;
$msg = wfMsgExt( 'pagecategories', array( 'parsemag',
'escapenoentities' ), count( $allCats['normal'] ) );
- $s .= '<div id="mw-normal-catlinks">' .
+ $s .= '<div id="mw-normal-catlinks"
class="mw-normal-catlinks">' .
Linker::link( Title::newFromText(
wfMsgForContent( 'pagecategorieslink' ) ), $msg )
. $colon . '<ul>' . $t . '</ul>' . '</div>';
}
@@ -422,14 +422,14 @@
# Hidden categories
if ( isset( $allCats['hidden'] ) ) {
if ( $this->getUser()->getBoolOption( 'showhiddencats'
) ) {
- $class = 'mw-hidden-cats-user-shown';
+ $class = ' mw-hidden-cats-user-shown';
} elseif ( $this->getTitle()->getNamespace() ==
NS_CATEGORY ) {
- $class = 'mw-hidden-cats-ns-shown';
+ $class = ' mw-hidden-cats-ns-shown';
} else {
- $class = 'mw-hidden-cats-hidden';
+ $class = ' mw-hidden-cats-hidden';
}
- $s .= "<div id=\"mw-hidden-catlinks\"
class=\"$class\">" .
+ $s .= "<div id=\"mw-hidden-catlinks\"
class=\"mw-hidden-catlinks$class\">" .
wfMsgExt( 'hidden-categories', array(
'parsemag', 'escapenoentities' ), count( $allCats['hidden'] ) ) .
$colon . '<ul>' . $embed . implode(
"{$pop}{$embed}" , $allCats['hidden'] ) . $pop . '</ul>' .
'</div>';
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
