http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96680
Revision: 96680
Author: brion
Date: 2011-09-09 18:43:37 +0000 (Fri, 09 Sep 2011)
Log Message:
-----------
Followup r87986: qunit test case for bug 30825
jQuery's $.append() and friends go through some funky code paths which
sometimes manually load <script> node contents via AJAX and eval them. That
failed entirely in IE 7 if given a protocol-relative link ($wgServer =
'//commons.wikimedia.org').
The fix in r87986 bypasses that by using DOM append directly on a script node,
and thus fixes bug 30825 without even knowing it. :)
This test serves as a regression test.
Modified Paths:
--------------
trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.test.js
Added Paths:
-----------
trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.test.bug30825.js
Added:
trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.test.bug30825.js
===================================================================
---
trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.test.bug30825.js
(rev 0)
+++
trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.test.bug30825.js
2011-09-09 18:43:37 UTC (rev 96680)
@@ -0,0 +1,2 @@
+start();
+ok( true, "Bug 30825 -- protocol-relative URL script load via mw.loader.load");
Property changes on:
trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.test.bug30825.js
___________________________________________________________________
Added: svn:eol-style
+ native
Modified: trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.test.js
===================================================================
--- trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.test.js
2011-09-09 18:39:51 UTC (rev 96679)
+++ trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.test.js
2011-09-09 18:43:37 UTC (rev 96680)
@@ -169,6 +169,23 @@
});
});
+test( 'mw.loader.bug30825', function() {
+ // This bug was actually already fixed in 1.18 and later when
discovered in 1.17.
+ // Test is for regressions!
+
+ expect(1);
+
+ // Confirm that mw.loader.load() works with protocol-relative URLs
+ var loc = window.location,
+ base = ('//' + loc.hostname +
loc.pathname).replace(/\/[^\/]*$/, ''),
+ target = base +
'/suites/resources/mediawiki/mediawiki.test.bug30825.js';
+
+ // Async! Include a timeout, as failure in this test leads to neither
the
+ // success nor failure callbacks getting called.
+ stop(5000);
+ mw.loader.load( target );
+});
+
test( 'mw.html', function() {
expect(11);
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
