http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97744

Revision: 97744
Author:   reedy
Date:     2011-09-21 16:34:23 +0000 (Wed, 21 Sep 2011)
Log Message:
-----------
Comment out unreachable code

Remove unreachable return false;

Modified Paths:
--------------
    trunk/phase3/includes/Export.php
    trunk/phase3/includes/WebRequest.php

Modified: trunk/phase3/includes/Export.php
===================================================================
--- trunk/phase3/includes/Export.php    2011-09-21 16:00:20 UTC (rev 97743)
+++ trunk/phase3/includes/Export.php    2011-09-21 16:34:23 UTC (rev 97744)
@@ -480,10 +480,10 @@
         */
        function closePage() {
                return "  </page>\n";
-               if ( !$this->firstPageWritten ) {
-                       $this->firstPageWritten = $this->pageInProgress;
-               }
-               $this->lastPageWritten = $this->pageInProgress;
+               //if ( !$this->firstPageWritten ) {
+               //      $this->firstPageWritten = $this->pageInProgress;
+               //}
+               //$this->lastPageWritten = $this->pageInProgress;
        }
 
        /**
@@ -711,7 +711,7 @@
 
        /**
         * Close the old file, and move it to a specified name.
-        * Use this for the last piece of a file written out 
+        * Use this for the last piece of a file written out
         * at specified checkpoints (e.g. every n hours).
         * @param $newname mixed File name. May be a string or an array with 
one element
         * @param $open bool If true, a new file with the old filename will be 
opened again for writing (default: false)

Modified: trunk/phase3/includes/WebRequest.php
===================================================================
--- trunk/phase3/includes/WebRequest.php        2011-09-21 16:00:20 UTC (rev 
97743)
+++ trunk/phase3/includes/WebRequest.php        2011-09-21 16:34:23 UTC (rev 
97744)
@@ -876,8 +876,6 @@
                        }
                        throw new HttpError( 403,
                                'Invalid file extension found in the path info 
or query string.' );
-
-                       return false;
                }
                return true;
        }


_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to