http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97785
Revision: 97785
Author: tstarling
Date: 2011-09-22 03:37:39 +0000 (Thu, 22 Sep 2011)
Log Message:
-----------
Removed the redundant wfMkdirParents() call added to
BitmapHandler::doTransform() in r79845. This causes problems on Wikimedia due
to incorrect NFS access. If a sysadmin misconfigures their thumbnail
destination directory, they should get a helpful error message, it shouldn't
transparently fall back to client-side scaling and cache the resulting HTML
forever.
Modified Paths:
--------------
trunk/phase3/includes/media/Bitmap.php
Modified: trunk/phase3/includes/media/Bitmap.php
===================================================================
--- trunk/phase3/includes/media/Bitmap.php 2011-09-22 03:28:21 UTC (rev
97784)
+++ trunk/phase3/includes/media/Bitmap.php 2011-09-22 03:37:39 UTC (rev
97785)
@@ -223,13 +223,6 @@
} else {
$scaler = 'client';
}
-
- if ( $scaler != 'client' && $dstPath ) {
- if ( !wfMkdirParents( dirname( $dstPath ), null,
__METHOD__ ) ) {
- # Unable to create a path for the thumbnail
- return 'client';
- }
- }
return $scaler;
}
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
