http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97846
Revision: 97846
Author: reedy
Date: 2011-09-22 20:07:44 +0000 (Thu, 22 Sep 2011)
Log Message:
-----------
Fix r97837 properly
Fix documentation in DiffHighlighter.php
Modified Paths:
--------------
trunk/extensions/CodeReview/backend/CodeRevision.php
trunk/extensions/CodeReview/backend/DiffHighlighter.php
Modified: trunk/extensions/CodeReview/backend/CodeRevision.php
===================================================================
--- trunk/extensions/CodeReview/backend/CodeRevision.php 2011-09-22
20:03:58 UTC (rev 97845)
+++ trunk/extensions/CodeReview/backend/CodeRevision.php 2011-09-22
20:07:44 UTC (rev 97846)
@@ -778,10 +778,11 @@
public function getComments( $attached = false ) {
$conditions = array(
'cc_repo_id' => $this->repoId,
- 'cc_rev_id' => $this->id );
+ 'cc_rev_id' => $this->id
+ );
if( $attached ) {
- $conditions['cc_patch_line'] = '!= null';
+ $conditions[] = 'cc_patch_line != null';
} else {
$conditions['cc_patch_line'] = null;
}
Modified: trunk/extensions/CodeReview/backend/DiffHighlighter.php
===================================================================
--- trunk/extensions/CodeReview/backend/DiffHighlighter.php 2011-09-22
20:03:58 UTC (rev 97845)
+++ trunk/extensions/CodeReview/backend/DiffHighlighter.php 2011-09-22
20:07:44 UTC (rev 97846)
@@ -13,9 +13,14 @@
/* line number inside patch */
protected $lineNumber = 0;
- /* CodeRepository: The repository for this revision */
+ /**
+ * @var CodeRepositor The repository for this revision
+ */
protected $repo = null;
- /* CodeRevision: revision the diff comes from */
+
+ /**
+ * @var CodeRevision revision the diff comes from
+ */
protected $rev = null;
/**
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
