http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97975

Revision: 97975
Author:   catrope
Date:     2011-09-23 23:24:15 +0000 (Fri, 23 Sep 2011)
Log Message:
-----------
Special:MoodBarFeedback: if there are no results, show a message and don't show 
the paging links

Modified Paths:
--------------
    trunk/extensions/MoodBar/MoodBar.i18n.php
    trunk/extensions/MoodBar/SpecialMoodBarFeedback.php

Modified: trunk/extensions/MoodBar/MoodBar.i18n.php
===================================================================
--- trunk/extensions/MoodBar/MoodBar.i18n.php   2011-09-23 23:16:30 UTC (rev 
97974)
+++ trunk/extensions/MoodBar/MoodBar.i18n.php   2011-09-23 23:24:15 UTC (rev 
97975)
@@ -83,6 +83,7 @@
        'moodbar-feedback-filters-button' => 'Set filters',
        'moodbar-feedback-whatis' => 'What is this feature?',
        'moodbar-feedback-permalink' => 'link to here',
+       'moodbar-feedback-noresults' => 'There are no comments that match your 
filters.',
        // Mood types
        'moodbar-type-happy' => 'Happy',
        'moodbar-type-sad' => 'Sad',

Modified: trunk/extensions/MoodBar/SpecialMoodBarFeedback.php
===================================================================
--- trunk/extensions/MoodBar/SpecialMoodBarFeedback.php 2011-09-23 23:16:30 UTC 
(rev 97974)
+++ trunk/extensions/MoodBar/SpecialMoodBarFeedback.php 2011-09-23 23:24:15 UTC 
(rev 97975)
@@ -86,7 +86,7 @@
        public function buildList( $rows ) {
                global $wgLang;
                $now = wfTimestamp( TS_UNIX );
-               $html = '<ul id="fbd-list">';
+               $list = '';
                foreach ( $rows as $row ) {
                        $type = $row->mbf_type;
                        $typeMsg = wfMessage( "moodbar-type-$type" )->escaped();
@@ -100,7 +100,7 @@
                        $permalinkURL = $this->getTitle( $row->mbf_id 
)->getLinkURL();
                        $permalinkText = wfMessage( 
'moodbar-feedback-permalink' )->escaped();
                        
-                       $html .= <<<HTML
+                       $list .= <<<HTML
                        <li class="fbd-item">
                                <div class="fbd-item-emoticon 
fbd-item-emoticon-$type">
                                        <span 
class="fbd-item-emoticon-label">$typeMsg</span>
@@ -118,11 +118,14 @@
                        </li>
 HTML;
                }
-               
-               $moreURL = '#'; //TODO
-               $moreText = wfMessage( 'moodbar-feedback-more' )->escaped();
-               $html .= '</ul><div id="fbd-list-more"><a 
href="#">More</a></div>';
-               return $html;
+               if ( $list === '' ) {
+                       return '<div id="fbd-list">' . wfMessage( 
'moodbar-feedback-noresults' )->escaped() . '</div>';
+               } else {
+                       // Only show paging stuff if the result is not empty
+                       $moreURL = '#'; //TODO
+                       $moreText = wfMessage( 'moodbar-feedback-more' 
)->escaped();
+                       return "<ul id=\"fbd-list\">$list</ul>" . '<div 
id="fbd-list-more"><a href="#">More</a></div>';
+               }
        }
        
        public function doQuery( $filters ) {


_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to