http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98041
Revision: 98041
Author: aaron
Date: 2011-09-24 22:14:36 +0000 (Sat, 24 Sep 2011)
Log Message:
-----------
Made ApiReviewActivity.php require an edit token
Modified Paths:
--------------
trunk/extensions/FlaggedRevs/api/actions/ApiReviewActivity.php
trunk/extensions/FlaggedRevs/presentation/modules/review.js
Modified: trunk/extensions/FlaggedRevs/api/actions/ApiReviewActivity.php
===================================================================
--- trunk/extensions/FlaggedRevs/api/actions/ApiReviewActivity.php
2011-09-24 22:11:40 UTC (rev 98040)
+++ trunk/extensions/FlaggedRevs/api/actions/ApiReviewActivity.php
2011-09-24 22:14:36 UTC (rev 98041)
@@ -102,7 +102,8 @@
return array(
'previd' => null,
'oldid' => null,
- 'reviewing' => array( ApiBase::PARAM_TYPE => array( 0,
1 ) )
+ 'reviewing' => array( ApiBase::PARAM_TYPE => array( 0,
1 ) ),
+ 'token' => null,
);
}
@@ -111,6 +112,7 @@
'previd' => 'The prior revision ID (for
reviewing changes only)',
'oldid' => 'The ID of the revision being
reviewed',
'reviewing' => 'Whether to advertising as reviewing or
no longer reviewing',
+ 'token' => 'A token previously obtained through
the gettoken parameter or prop=info',
);
}
@@ -130,11 +132,11 @@
}
public function needsToken() {
- return false;
+ return true;
}
- public function getTokenSalt() {
- return false;
+ public function getTokenSalt() {
+ return '';
}
public function getExamples() {
Modified: trunk/extensions/FlaggedRevs/presentation/modules/review.js
===================================================================
--- trunk/extensions/FlaggedRevs/presentation/modules/review.js 2011-09-24
22:11:40 UTC (rev 98040)
+++ trunk/extensions/FlaggedRevs/presentation/modules/review.js 2011-09-24
22:14:36 UTC (rev 98041)
@@ -387,7 +387,9 @@
action : 'reviewactivity',
previd : oRevId,
oldid : nRevId,
- reviewing : value
+ reviewing : value,
+ token :
mw.user.tokens.get('editToken'),
+ format : 'json'
},
type : "POST",
dataType: "html", // response type
@@ -396,11 +398,13 @@
});
}
if ( call.status == 200 ) {
- FlaggedRevsReview.isUserReviewing = value;
- return true;
- } else {
- return false;
+ var s = jQuery.parseJSON( call.responseText );
+ if ( s && s.reviewactivity && s.reviewactivity.result
== "Success" ) {
+ FlaggedRevsReview.isUserReviewing = value;
+ return true;
+ }
}
+ return false;
}
};
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
