http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99632

Revision: 99632
Author:   bawolff
Date:     2011-10-12 14:13:06 +0000 (Wed, 12 Oct 2011)
Log Message:
-----------
(bug 31637) Do not extract tiff:Orientation from XMP data, since then it will 
be used to rotate images, which is kind of unexpected.

Most people only really expect the Exif data to be used for rotating images (if 
that), so its unexpected when the xmp property causes an image to be rotated. 
So disable extracting that property from XMP.

Modified Paths:
--------------
    trunk/phase3/includes/media/XMPInfo.php

Modified: trunk/phase3/includes/media/XMPInfo.php
===================================================================
--- trunk/phase3/includes/media/XMPInfo.php     2011-10-12 13:15:16 UTC (rev 
99631)
+++ trunk/phase3/includes/media/XMPInfo.php     2011-10-12 14:13:06 UTC (rev 
99632)
@@ -557,13 +557,16 @@
                                'map_group' => 'exif',
                                'mode'      => XMPReader::MODE_SIMPLE,
                        ),
-                       'Orientation'       => array(
-                               'map_group' => 'exif',
-                               'mode'      => XMPReader::MODE_SIMPLE,
-                               'validate'  => 'validateClosed',
-                               'choices'   => array( '1' => true, '2' => true, 
'3' => true, '4' => true, 5 => true,
-                                               '6' => true, '7' => true, '8' 
=> true ),
-                       ),
+                       /**** Do not extract this property
+                        * It interferes with auto exif rotation.
+                        * 'Orientation'       => array(
+                        *      'map_group' => 'exif',
+                        *      'mode'      => XMPReader::MODE_SIMPLE,
+                        *      'validate'  => 'validateClosed',
+                        *      'choices'   => array( '1' => true, '2' => true, 
'3' => true, '4' => true, 5 => true,
+                        *                      '6' => true, '7' => true, '8' 
=> true ),
+                        *),
+                        ******/
                        'PhotometricInterpretation' => array(
                                'map_group' => 'exif',
                                'mode'      => XMPReader::MODE_SIMPLE,


_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to