http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99736
Revision: 99736
Author: tparscal
Date: 2011-10-13 21:37:20 +0000 (Thu, 13 Oct 2011)
Log Message:
-----------
More fixes based on static code analysis
Modified Paths:
--------------
trunk/parsers/wikidom/lib/hype/bases/es.DocumentModelNode.js
trunk/parsers/wikidom/lib/hype/bases/es.EventEmitter.js
trunk/parsers/wikidom/lib/hype/bases/es.ModelNode.js
trunk/parsers/wikidom/lib/hype/bases/es.ViewNode.js
trunk/parsers/wikidom/lib/hype/es.js
Modified: trunk/parsers/wikidom/lib/hype/bases/es.DocumentModelNode.js
===================================================================
--- trunk/parsers/wikidom/lib/hype/bases/es.DocumentModelNode.js
2011-10-13 21:32:15 UTC (rev 99735)
+++ trunk/parsers/wikidom/lib/hype/bases/es.DocumentModelNode.js
2011-10-13 21:37:20 UTC (rev 99736)
@@ -58,13 +58,15 @@
};
es.DocumentModelNode.prototype.onBeforeSplice = function( index, howmany ) {
- var diff = 0,
+ var i,
+ length,
+ diff = 0,
removed = this.slice( index, index + howmany ),
added = Array.prototype.slice.call( arguments, 2 );
- for ( var i = 0; i < removed.length; i++ ) {
+ for ( i = 0, length = removed.length; i < length; i++ ) {
diff -= removed[i].getElementLength();
}
- for ( var i = 0; i < added.length; i++ ) {
+ for ( i = 0, length = added.length; i < length; i++ ) {
diff += added[i].getElementLength();
}
this.adjustContentLength( diff );
Modified: trunk/parsers/wikidom/lib/hype/bases/es.EventEmitter.js
===================================================================
--- trunk/parsers/wikidom/lib/hype/bases/es.EventEmitter.js 2011-10-13
21:32:15 UTC (rev 99735)
+++ trunk/parsers/wikidom/lib/hype/bases/es.EventEmitter.js 2011-10-13
21:37:20 UTC (rev 99736)
@@ -7,7 +7,7 @@
*/
es.EventEmitter = function() {
this.events = {};
-}
+};
/* Methods */
@@ -144,7 +144,7 @@
return this;
}
var handlers = this.events[type];
- if ( handlers.length == 1 && handlers[0] === listener ) {
+ if ( handlers.length === 1 && handlers[0] === listener ) {
delete this.events[type];
} else {
var i = handlers.indexOf( listener );
@@ -152,7 +152,7 @@
return this;
}
handlers.splice( i, 1 );
- if ( handlers.length == 0 ) {
+ if ( handlers.length === 0 ) {
delete this.events[type];
}
}
Modified: trunk/parsers/wikidom/lib/hype/bases/es.ModelNode.js
===================================================================
--- trunk/parsers/wikidom/lib/hype/bases/es.ModelNode.js 2011-10-13
21:32:15 UTC (rev 99735)
+++ trunk/parsers/wikidom/lib/hype/bases/es.ModelNode.js 2011-10-13
21:37:20 UTC (rev 99736)
@@ -16,7 +16,7 @@
es.EventEmitter.call( this );
// Extension
- var node = $.extend( [], this )
+ var node = $.extend( [], this );
// Reusable function for passing update events upstream
node.emitUpdate = function() {
@@ -136,15 +136,17 @@
* @emits update
*/
es.ModelNode.prototype.splice = function( index, howmany ) {
- var args = Array.prototype.slice.call( arguments, 0 );
+ var i,
+ length,
+ args = Array.prototype.slice.call( arguments, 0 );
this.emit.apply( this, ['beforeSplice'].concat( args ) );
if ( args.length >= 3 ) {
- for ( var i = 2; i < args.length; i++ ) {
+ for ( i = 2, length = args.length; i < length; i++ ) {
args[i].attach( this );
}
}
var removed = Array.prototype.splice.apply( this, args );
- for ( var i = 0; i < removed.length; i++ ) {
+ for ( i = 0, length = removed.length; i < length; i++ ) {
removed[i].detach();
removed[i].removeListener( 'update', this.emitUpdate );
}
Modified: trunk/parsers/wikidom/lib/hype/bases/es.ViewNode.js
===================================================================
--- trunk/parsers/wikidom/lib/hype/bases/es.ViewNode.js 2011-10-13 21:32:15 UTC
(rev 99735)
+++ trunk/parsers/wikidom/lib/hype/bases/es.ViewNode.js 2011-10-13 21:37:20 UTC
(rev 99736)
@@ -27,7 +27,7 @@
}
// Extension
- var node = $.extend( [], this )
+ var node = $.extend( [], this );
// Properties
node.model = model;
Modified: trunk/parsers/wikidom/lib/hype/es.js
===================================================================
--- trunk/parsers/wikidom/lib/hype/es.js 2011-10-13 21:32:15 UTC (rev
99735)
+++ trunk/parsers/wikidom/lib/hype/es.js 2011-10-13 21:37:20 UTC (rev
99736)
@@ -62,9 +62,9 @@
bValue = b[k];
aType = typeof aValue;
bType = typeof bValue;
- if ( aType !== bType
- || ( ( aType === 'string' || aType === 'number'
) && aValue !== bValue )
- || ( $.isPlainObject( aValue ) &&
!es.compareObjects( aValue, bValue ) ) ) {
+ if ( aType !== bType ||
+ ( ( aType === 'string' || aType === 'number' ) &&
aValue !== bValue ) ||
+ ( $.isPlainObject( aValue ) && !es.compareObjects(
aValue, bValue ) ) ) {
return false;
}
}
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
