http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99766
Revision: 99766
Author: inez
Date: 2011-10-14 14:30:08 +0000 (Fri, 14 Oct 2011)
Log Message:
-----------
Change the way how offsets based on position are being figured out
Modified Paths:
--------------
trunk/parsers/wikidom/lib/synth/views/es.ContentView.js
trunk/parsers/wikidom/lib/synth/views/es.DocumentView.js
trunk/parsers/wikidom/lib/synth/views/es.ListBlockView.js
trunk/parsers/wikidom/lib/synth/views/es.TableBlockRowView.js
trunk/parsers/wikidom/lib/synth/views/es.TableBlockView.js
Modified: trunk/parsers/wikidom/lib/synth/views/es.ContentView.js
===================================================================
--- trunk/parsers/wikidom/lib/synth/views/es.ContentView.js 2011-10-14
14:20:02 UTC (rev 99765)
+++ trunk/parsers/wikidom/lib/synth/views/es.ContentView.js 2011-10-14
14:30:08 UTC (rev 99766)
@@ -309,7 +309,7 @@
top = 0;
while ( i < lineCount ) {
top += this.lines[i].height;
- if ( position.top <= top ) {
+ if ( position.top < top ) {
break;
}
i++;
Modified: trunk/parsers/wikidom/lib/synth/views/es.DocumentView.js
===================================================================
--- trunk/parsers/wikidom/lib/synth/views/es.DocumentView.js 2011-10-14
14:20:02 UTC (rev 99765)
+++ trunk/parsers/wikidom/lib/synth/views/es.DocumentView.js 2011-10-14
14:30:08 UTC (rev 99766)
@@ -87,15 +87,15 @@
return 0;
}
- var blockView = this.items[0];
+ var blockView;
for ( var i = 0; i < this.items.length; i++ ) {
- if ( this.items[i].$.offset().top >= position.top ) {
+ if ( this.items[i].$.offset().top > position.top ) {
break;
}
blockView = this.items[i];
}
-
+
return blockView.list.items.offsetOf( blockView ) +
blockView.getOffsetFromPosition( position );
};
Modified: trunk/parsers/wikidom/lib/synth/views/es.ListBlockView.js
===================================================================
--- trunk/parsers/wikidom/lib/synth/views/es.ListBlockView.js 2011-10-14
14:20:02 UTC (rev 99765)
+++ trunk/parsers/wikidom/lib/synth/views/es.ListBlockView.js 2011-10-14
14:30:08 UTC (rev 99766)
@@ -73,17 +73,17 @@
if ( this.items.length === 0 ) {
return 0;
}
-
- var listItemView = this.items[0];
+ var listItemView;
+
for ( var i = 0; i < this.items.length; i++ ) {
- if ( this.items[i].$.offset().top >= position.top ) {
+ if ( this.items[i].$.offset().top > position.top ) {
break;
}
listItemView = this.items[i];
}
-
- return listItemView.list.items.offsetOf( listItemView ) +
listItemView.getOffsetFromPosition( position );
+
+ return listItemView.list.items.offsetOf( listItemView ) +
listItemView.getOffsetFromPosition( position );
};
/**
Modified: trunk/parsers/wikidom/lib/synth/views/es.TableBlockRowView.js
===================================================================
--- trunk/parsers/wikidom/lib/synth/views/es.TableBlockRowView.js
2011-10-14 14:20:02 UTC (rev 99765)
+++ trunk/parsers/wikidom/lib/synth/views/es.TableBlockRowView.js
2011-10-14 14:30:08 UTC (rev 99766)
@@ -69,16 +69,16 @@
if ( this.items.length === 0 ) {
return 0;
}
-
- var cellView = this.items[0];
+ var cellView;
+
for ( var i = 0; i < this.items.length; i++ ) {
- if ( this.items[i].$.offset().left >= position.left ) {
+ if ( this.items[i].$.offset().left > position.left ) {
break;
}
cellView = this.items[i];
}
-
+
return cellView.list.items.offsetOf( cellView ) +
cellView.getOffsetFromPosition( position );
};
Modified: trunk/parsers/wikidom/lib/synth/views/es.TableBlockView.js
===================================================================
--- trunk/parsers/wikidom/lib/synth/views/es.TableBlockView.js 2011-10-14
14:20:02 UTC (rev 99765)
+++ trunk/parsers/wikidom/lib/synth/views/es.TableBlockView.js 2011-10-14
14:30:08 UTC (rev 99766)
@@ -71,16 +71,16 @@
return 0;
}
- var rowView = this.items[0];
+ var rowView;
for ( var i = 0; i < this.items.length; i++ ) {
- if ( this.items[i].$.offset().top >= position.top ) {
+ if ( this.items[i].$.offset().top > position.top ) {
break;
}
rowView = this.items[i];
}
-
- return rowView.list.items.offsetOf( rowView ) +
rowView.getOffsetFromPosition( position );
+
+ return rowView.list.items.offsetOf( rowView ) +
rowView.getOffsetFromPosition( position );
};
/**
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
