http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100092
Revision: 100092
Author: krinkle
Date: 2011-10-17 22:35:10 +0000 (Mon, 17 Oct 2011)
Log Message:
-----------
ext.codereview.js: Fix bug 31785
* indexOf prototype does not exist on the Number object. Convert to string
before calling indexOf.
* (bug 31785) ext.codereview.js should ensure type string before calling
indexOf (Uncaught TypeError)
Modified Paths:
--------------
trunk/extensions/CodeReview/modules/ext.codereview.js
Modified: trunk/extensions/CodeReview/modules/ext.codereview.js
===================================================================
--- trunk/extensions/CodeReview/modules/ext.codereview.js 2011-10-17
21:31:50 UTC (rev 100091)
+++ trunk/extensions/CodeReview/modules/ext.codereview.js 2011-10-17
22:35:10 UTC (rev 100092)
@@ -26,7 +26,7 @@
good = false;
}
}
- if( good && tags[i].indexOf( lastTag )
!= -1 ){
+ if( good && ('' + tags[i]).indexOf(
lastTag ) != -1 ){
suggestions.push( doneTags +
tags[i] );
}
}
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
