[MediaWiki-CVS] SVN: [100148] trunk/extensions/Contest/specials/SpecialMyContests.php

[reedy]

http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100148

Revision: 100148
Author:   reedy
Date:     2011-10-18 19:56:55 +0000 (Tue, 18 Oct 2011)
Log Message:
-----------
Create some temporary variables rather than a load of chained method calls

Modified Paths:
--------------
    trunk/extensions/Contest/specials/SpecialMyContests.php

Modified: trunk/extensions/Contest/specials/SpecialMyContests.php
===================================================================
--- trunk/extensions/Contest/specials/SpecialMyContests.php     2011-10-18 
19:42:52 UTC (rev 100147)
+++ trunk/extensions/Contest/specials/SpecialMyContests.php     2011-10-18 
19:56:55 UTC (rev 100148)
@@ -275,24 +275,27 @@
         * @param ContestContestant $contestant
         */
        protected function showSubmissionPage( ContestContestant $contestant ) {
-               if ( $this->getRequest()->getCheck( 'new' ) ) {
-                       $this->showSuccess( 
'contest-mycontests-signup-success', $contestant->getContest()->getField( 
'name' ) );
+               $request = $this->getRequest();
+               $contest = $contestant->getContest();
+               if ( $request->getCheck( 'new' ) ) {
+                       $this->showSuccess( 
'contest-mycontests-signup-success', $contest->getField( 'name' ) );
                }
-               else if ( $this->getRequest()->getCheck( 'added' ) ) {
+               else if ( $request->getCheck( 'added' ) ) {
                        $this->showSuccess( 
'contest-mycontests-addition-success' );
                }
-               else if ( $this->getRequest()->getCheck( 'updated' ) ) {
+               else if ( $request->getCheck( 'updated' ) ) {
                        $this->showSuccess( 
'contest-mycontests-updated-success' );
                }
-               else if ( $this->getRequest()->wasPosted()
-                       && !$this->getUser()->matchEditToken( 
$this->getRequest()->getVal( 'wpEditToken' ) ) ) {
+               else if ( $request->wasPosted()
+                       && !$this->getUser()->matchEditToken( $request->getVal( 
'wpEditToken' ) ) ) {
                        $this->showError( 'contest-mycontests-sessionfail' );
                }
 
-               $this->getOutput()->setPageTitle( 
$contestant->getContest()->getField( 'name' ) );
+               $output = $this->getOutput();
+               $output->setPageTitle( $contest->getField( 'name' ) );
 
-               $this->getOutput()->addHTML('<div style="clear:both;"></div>');
-               $this->getOutput()->addWikiMsg( 'contest-submission-header', 
$contestant->getContest()->getField( 'name' ) );
+               $output->addHTML('<div style="clear:both;"></div>');
+               $output->addWikiMsg( 'contest-submission-header', 
$contest->getField( 'name' ) );
 
                $form = new HTMLForm( $this->getFormFields( $contestant ), 
$this->getContext() );
 
@@ -301,10 +304,10 @@
 
                if( $form->show() ) {
                        $query = is_null( $this->submissionState ) ? '' : 
$this->submissionState;
-                       $this->getOutput()->redirect( $this->getTitle( 
$contestant->getContest()->getField( 'name' ) )->getLocalURL( $query ) );
+                       $output->redirect( $this->getTitle( $contest->getField( 
'name' ) )->getLocalURL( $query ) );
                }
                else {
-                       $this->getOutput()->addModules( 
'contest.special.submission' );
+                       $output->addModules( 'contest.special.submission' );
                }
        }
 


_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs