https://www.mediawiki.org/wiki/Special:Code/MediaWiki/102005

Revision: 102005
Author:   nikerabbit
Date:     2011-11-04 16:12:03 +0000 (Fri, 04 Nov 2011)
Log Message:
-----------
Add global which was undefined, simplify the checks which causes wrong codepath 
to be taken too

Modified Paths:
--------------
    trunk/extensions/Translate/Translate.php
    trunk/extensions/Translate/specials/SpecialMessageGroupStats.php

Modified: trunk/extensions/Translate/Translate.php
===================================================================
--- trunk/extensions/Translate/Translate.php    2011-11-04 16:00:31 UTC (rev 
102004)
+++ trunk/extensions/Translate/Translate.php    2011-11-04 16:12:03 UTC (rev 
102005)
@@ -510,7 +510,12 @@
  */
 $wgTranslateGroupFiles = array();
 
+/**
+ * @todo document
+ */
+$wgTranslateWorkflowStates = false;
 
+
 # === System setup related configuration ===
 
 /**

Modified: trunk/extensions/Translate/specials/SpecialMessageGroupStats.php
===================================================================
--- trunk/extensions/Translate/specials/SpecialMessageGroupStats.php    
2011-11-04 16:00:31 UTC (rev 102004)
+++ trunk/extensions/Translate/specials/SpecialMessageGroupStats.php    
2011-11-04 16:12:03 UTC (rev 102005)
@@ -108,7 +108,7 @@
                $table = $this->table;
 
                global $wgTranslateWorkflowStates;
-               if ( $wgTranslateWorkflowStates !== false ) {
+               if ( $wgTranslateWorkflowStates ) {
                        $this->states = self::getWorkflowStates( $this->target 
);
                        $this->statemap = array_flip( 
$wgTranslateWorkflowStates );
                        $table->addExtraColumn( wfMessage( 
'translate-stats-workflow' ) );
@@ -179,7 +179,7 @@
                $out .= "\n\t\t" . $this->getMainColumnCell( $code, $extra );
                $out .= $this->table->makeNumberColumns( $fuzzy, $translated, 
$total );
                global $wgTranslateWorkflowStates;
-               if ( $wgTranslateWorkflowStates !== false ) {
+               if ( $wgTranslateWorkflowStates ) {
                        $state = isset( $this->states[$code] ) ? 
$this->states[$code] : '';
                        $sort = isset( $this->statemap[$state] ) ? 
$this->statemap[$state] + 1 : -1;
                        $out .= "\n\t\t" . $this->table->element( $state, 
false, $sort );


_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to