https://www.mediawiki.org/wiki/Special:Code/MediaWiki/102151

Revision: 102151
Author:   jpostlethwaite
Date:     2011-11-06 04:15:29 +0000 (Sun, 06 Nov 2011)
Log Message:
-----------
Moved the method addKeyToTransaction() out of parent class. The logic was 
gateway specific. Resolves r102086.

Modified Paths:
--------------
    trunk/extensions/DonationInterface/gateway_common/gateway.adapter.php
    
trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php

Modified: trunk/extensions/DonationInterface/gateway_common/gateway.adapter.php
===================================================================
--- trunk/extensions/DonationInterface/gateway_common/gateway.adapter.php       
2011-11-06 04:11:20 UTC (rev 102150)
+++ trunk/extensions/DonationInterface/gateway_common/gateway.adapter.php       
2011-11-06 04:15:29 UTC (rev 102151)
@@ -585,18 +585,6 @@
 
                return $this->transactions[$transaction]['request'];
        }
-
-       /**
-        * Add a key to the transaction INSERT_ORDERWITHPAYMENT.
-        *
-        * 
$this->transactions['INSERT_ORDERWITHPAYMENT']['request']['REQUEST']['PARAMS'][ 
$key ][] = $value 
-        */
-       protected function addKeyToTransaction( $value, $type = 'PAYMENT' ) {
-
-               if ( !in_array( $value, 
$this->transactions['INSERT_ORDERWITHPAYMENT']['request']['REQUEST']['PARAMS'][ 
$type ] ) ) {
-                       
$this->transactions['INSERT_ORDERWITHPAYMENT']['request']['REQUEST']['PARAMS'][ 
$type ][] = $value;
-               }
-       }
        
        /**
         * Builds a set of transaction data in name/value format

Modified: 
trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php
===================================================================
--- 
trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php
  2011-11-06 04:11:20 UTC (rev 102150)
+++ 
trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php
  2011-11-06 04:15:29 UTC (rev 102151)
@@ -7,6 +7,18 @@
        const GLOBAL_PREFIX = 'wgGlobalCollectGateway';
 
        /**
+        * Add a key to the transaction INSERT_ORDERWITHPAYMENT.
+        *
+        * 
$this->transactions['INSERT_ORDERWITHPAYMENT']['request']['REQUEST']['PARAMS'][ 
$key ][] = $value 
+        */
+       protected function addKeyToTransaction( $value, $type = 'PAYMENT' ) {
+
+               if ( !in_array( $value, 
$this->transactions['INSERT_ORDERWITHPAYMENT']['request']['REQUEST']['PARAMS'][ 
$type ] ) ) {
+                       
$this->transactions['INSERT_ORDERWITHPAYMENT']['request']['REQUEST']['PARAMS'][ 
$type ][] = $value;
+               }
+       }
+
+       /**
         * Define accountInfo
         */
        public function defineAccountInfo() {


_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to