https://www.mediawiki.org/wiki/Special:Code/MediaWiki/103511

Revision: 103511
Author:   foxtrott
Date:     2011-11-17 21:06:58 +0000 (Thu, 17 Nov 2011)
Log Message:
-----------
bugfixes (Undefined variable: userCanEditPage; Only variables should be passed 
by reference)

Modified Paths:
--------------
    trunk/extensions/SemanticForms/includes/SF_FormPrinter.php
    trunk/extensions/SemanticForms/specials/SF_RunQuery.php

Modified: trunk/extensions/SemanticForms/includes/SF_FormPrinter.php
===================================================================
--- trunk/extensions/SemanticForms/includes/SF_FormPrinter.php  2011-11-17 
20:58:13 UTC (rev 103510)
+++ trunk/extensions/SemanticForms/includes/SF_FormPrinter.php  2011-11-17 
21:06:58 UTC (rev 103511)
@@ -392,7 +392,7 @@
                        wfRunHooks( 'sfUserCanEditPage', array( 
$this->mPageTitle, &$userCanEditPage ) );
                }
                $form_text = "";
-               if ( $userCanEditPage || $is_query ) {
+               if ( $is_query || $userCanEditPage ) {
                        $form_is_disabled = false;
                        // Show "Your IP address will be recorded" warning if
                        // user is anonymous, and it's not a query -

Modified: trunk/extensions/SemanticForms/specials/SF_RunQuery.php
===================================================================
--- trunk/extensions/SemanticForms/specials/SF_RunQuery.php     2011-11-17 
20:58:13 UTC (rev 103510)
+++ trunk/extensions/SemanticForms/specials/SF_RunQuery.php     2011-11-17 
21:06:58 UTC (rev 103511)
@@ -154,8 +154,9 @@
                        $wgParser->getOutput()->addHeadItem( $script );
                } else {
                        $wgOut->addScript( $script );
-                       if ($wgParser->getOutput()) {
-                               $wgOut->addParserOutputNoText( 
$wgParser->getOutput() );
+                       $po = $wgParser->getOutput();
+                       if ( $po ) {
+                               $wgOut->addParserOutputNoText( $po );
                        }
                }
 


_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to