https://www.mediawiki.org/wiki/Special:Code/MediaWiki/106267
Revision: 106267
Author: rsterbin
Date: 2011-12-14 22:30:52 +0000 (Wed, 14 Dec 2011)
Log Message:
-----------
Tweaks to tracking ids for bug #32992:
- modules/ext.articleFeedbackv5/ext.articleFeedbackv5.js:
- The vertical link now has its own tracking id
- Made bucketName() outside-accessible
- modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js:
- Added bucket name to link events
Modified Paths:
--------------
trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.js
trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
Modified:
trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.js
===================================================================
---
trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.js
2011-12-14 22:27:41 UTC (rev 106266)
+++
trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.js
2011-12-14 22:30:52 UTC (rev 106267)
@@ -28,7 +28,9 @@
// Click event
var clickFeedbackLink = function ( $link ) {
- $aftDiv.articleFeedbackv5( 'trackClick', linkInfo[ $link.data( 'linkId'
) ].trackId );
+ var tracking_id = $aftDiv.articleFeedbackv5( 'bucketName' ) +
+ linkInfo[ $link.data( 'linkId' ) ].trackId;
+ $aftDiv.articleFeedbackv5( 'trackClick', tracking_id );
$aftDiv.articleFeedbackv5( 'openAsModal', $link );
};
Modified:
trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
===================================================================
---
trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
2011-12-14 22:27:41 UTC (rev 106266)
+++
trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
2011-12-14 22:30:52 UTC (rev 106267)
@@ -1902,7 +1902,8 @@
.attr( 'href', mw.msg(
'articlefeedbackv5-cta1-learn-how-url' ) );
// Fill in the link
- var edit_track_id =
$.articleFeedbackv5.ctaName() + '-button-click-' +
+ var edit_track_id =
$.articleFeedbackv5.bucketName() + '-' +
+ $.articleFeedbackv5.ctaName() +
'-button-click-' +
( $.articleFeedbackv5.inDialog ?
'overlay': 'bottom' );
$block.find( '.articleFeedbackv5-cta-button' )
.attr( 'href',
$.articleFeedbackv5.editUrl( edit_track_id ) );
@@ -1968,7 +1969,8 @@
// Fill in the button link
var learn_url = mw.msg(
'articlefeedbackv5-cta1-learn-how-url' );
- var learn_track_id =
$.articleFeedbackv5.ctaName() + '-button-click-' +
+ var learn_track_id =
$.articleFeedbackv5.bucketName() + '-' +
+ $.articleFeedbackv5.ctaName() +
'-button-click-' +
( $.articleFeedbackv5.inDialog ?
'overlay': 'bottom' );
$block.find( '.articleFeedbackv5-cta-button' )
.attr( 'href',
$.articleFeedbackv5.trackingUrl( learn_url, learn_track_id ) );
@@ -2656,7 +2658,8 @@
$.articleFeedbackv5.setDialogDimensions();
// Track the event
- $.articleFeedbackv5.trackClick(
$.articleFeedbackv5.ctaName() + '-impression-' +
+ $.articleFeedbackv5.trackClick(
$.articleFeedbackv5.bucketName() + '-' +
+ $.articleFeedbackv5.ctaName() + '-impression-' +
( $.articleFeedbackv5.inDialog ? 'overlay' :
'bottom' ) );
$.articleFeedbackv5.nowShowing = 'cta';
@@ -2911,7 +2914,8 @@
if ( 'form' == $.articleFeedbackv5.nowShowing ) {
$.articleFeedbackv5.trackClick(
$.articleFeedbackv5.bucketName() + '-overlay-close' );
} else if ('cta' == $.articleFeedbackv5.nowShowing ) {
- $.articleFeedbackv5.trackClick(
$.articleFeedbackv5.ctaName() + '-overlay-close' );
+ $.articleFeedbackv5.trackClick(
$.articleFeedbackv5.bucketName() + '-' +
+ $.articleFeedbackv5.ctaName() +
'-overlay-close' );
}
$.articleFeedbackv5.setLinkId( '0' );
$.articleFeedbackv5.$dialog.find(
'.articleFeedbackv5-tooltip' ).hide();
@@ -2979,6 +2983,7 @@
inDebug: { args: 0, ret: true },
nowShowing: { args: 0, ret: true },
prefix: { args: 1, ret: true },
+ bucketName: { args: 0, ret: true },
addToRemovalQueue: { args: 1, ret: false },
openAsModal: { args: 1, ret: false },
closeAsModal: { args: 0, ret: true },
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
