https://www.mediawiki.org/wiki/Special:Code/MediaWiki/106279

Revision: 106279
Author:   catrope
Date:     2011-12-14 23:16:25 +0000 (Wed, 14 Dec 2011)
Log Message:
-----------
1.18wmf1: Fix syntax errors in AFTv5 SQL file

Modified Paths:
--------------
    branches/wmf/1.18wmf1/extensions/ArticleFeedbackv5/sql/ArticleFeedbackv5.sql

Modified: 
branches/wmf/1.18wmf1/extensions/ArticleFeedbackv5/sql/ArticleFeedbackv5.sql
===================================================================
--- 
branches/wmf/1.18wmf1/extensions/ArticleFeedbackv5/sql/ArticleFeedbackv5.sql    
    2011-12-14 23:14:44 UTC (rev 106278)
+++ 
branches/wmf/1.18wmf1/extensions/ArticleFeedbackv5/sql/ArticleFeedbackv5.sql    
    2011-12-14 23:16:25 UTC (rev 106279)
@@ -89,26 +89,24 @@
   PRIMARY KEY (aa_feedback_id, aa_field_id)
 ) /*$wgDBTableOptions*/;
 
-/*
-These next four are rollup tables used by the articlefeedback special page.
-The revision tables store per-revision numers, as we (in meetings with WMF)
-agreed that per-revision numbers could be useful in reporting, though
-they aren't currently used on the feedback page. The page-level ones only
-count back to wgArticleFeedbackv5RatingLifetime, so they're a rolling window.
-
-There are tables for ratings and select (ratings includes booleans as well),
-because while the value of the rating/boolean is important (Rated 3/5), for
-selects we only want the count for each input, not the value of that input or
-the sum of the values (which will be numerical option_ids, not meaningful 
-rating values). The queries were sufficiently different that we deemed multiple
-tables worthwhile.
-*/
+--These next four are rollup tables used by the articlefeedback special page.
+--The revision tables store per-revision numers, as we (in meetings with WMF)
+--agreed that per-revision numbers could be useful in reporting, though
+--they aren't currently used on the feedback page. The page-level ones only
+--count back to wgArticleFeedbackv5RatingLifetime, so they're a rolling window.
+--
+--There are tables for ratings and select (ratings includes booleans as well),
+--because while the value of the rating/boolean is important (Rated 3/5), for
+--selects we only want the count for each input, not the value of that input or
+--the sum of the values (which will be numerical option_ids, not meaningful 
+--rating values). The queries were sufficiently different that we deemed 
multiple
+--tables worthwhile.
 CREATE TABLE IF NOT EXISTS /*_*/aft_article_feedback_ratings_rollup (
   arr_page_id   integer unsigned NOT NULL,
   arr_field_id  integer unsigned NOT NULL,
   arr_total     integer unsigned NOT NULL,
   arr_count     integer unsigned NOT NULL,
-  PRIMARY KEY (arr_page_id, arr_rating_id)
+  PRIMARY KEY (arr_page_id, arr_field_id)
 ) /*$wgDBTableOptions*/;
 
 CREATE TABLE IF NOT EXISTS /*_*/aft_article_revision_feedback_ratings_rollup (
@@ -117,7 +115,7 @@
   afrr_field_id     integer unsigned NOT NULL,
   afrr_total        integer unsigned NOT NULL,
   afrr_count        integer unsigned NOT NULL,
-  PRIMARY KEY (afrr_page_id, afrr_rating_id, afrr_revision_id)
+  PRIMARY KEY (afrr_page_id, afrr_field_id, afrr_revision_id)
 ) /*$wgDBTableOptions*/;
 
 CREATE TABLE IF NOT EXISTS /*_*/aft_article_feedback_select_rollup (


_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to