https://www.mediawiki.org/wiki/Special:Code/MediaWiki/106398
Revision: 106398 Author: krinkle Date: 2011-12-16 00:02:22 +0000 (Fri, 16 Dec 2011) Log Message: ----------- [WebFonts] Don't loop over an object unfiltered! * Fixes bug 33154 * Check https://bugzilla.wikimedia.org/show_bug.cgi?id=33154#c13 for elaborate description and trace Modified Paths: -------------- trunk/extensions/WebFonts/resources/ext.webfonts.js Modified: trunk/extensions/WebFonts/resources/ext.webfonts.js =================================================================== --- trunk/extensions/WebFonts/resources/ext.webfonts.js 2011-12-15 23:59:35 UTC (rev 106397) +++ trunk/extensions/WebFonts/resources/ext.webfonts.js 2011-12-16 00:02:22 UTC (rev 106398) @@ -279,6 +279,10 @@ mw.webfonts.set( $(this).val() ); } ); for ( var scheme in config ) { + if ( !Object.prototype.hasOwnProperty.call( config, scheme ) ) { + continue; + } + var $fontLink = $( '<input type="radio" name="font" />' ) .attr( 'id', fontID( config[scheme] ) ) .val( config[scheme] ); _______________________________________________ MediaWiki-CVS mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
